Comments (3)
Why '
is even needed in a first place? It makes using app from bash awkward :(
$ ./sfall-asm.exe patches/dialog_money_fix.asm --memory-args=\'patch=0x1207\'
Can it be something like --memory-args=name1=0x1207,name2=0x1337
?
Other thing - bytes
string have no longer guaranteed % 2 == 0 length, which breaks conversion for scripts :(
$ ./sfall-asm.exe patches/dialog_money_fix.asm --memory-args=\'patch=0x480E1F\'
from sfall-asm.
Implemented, but with a small adjustment, --memory-args
use ' instead of " to avoid escaping.
from sfall-asm.
It's not needed unless support for spaces is needed, which isn't needed, at the moment. It was more of a convention thing I guess. I'll remove it.
Thanks for once again catching me doing too little testing and error checking, I'll fix the byte string length by padding with zeroes, should fix the issue :)
from sfall-asm.
Related Issues (12)
- Address extraction too fragile
- Surround macros with begin/end when needed HOT 2
- Multibyte NOP not parsed correctly HOT 1
- Asm utility code HOT 4
- Report all errors on stderr HOT 1
- Allow updating header with user code
- Use dynamically allocated memory for patch code
- Switch to using `$` in global variables HOT 1
- Malloc improvements HOT 3
- Generation of assert patches
- VOODOO_Alloc called too early HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sfall-asm.