Giter Club home page Giter Club logo

Comments (3)

wipe2238 avatar wipe2238 commented on September 25, 2024 1

Why ' is even needed in a first place? It makes using app from bash awkward :(
$ ./sfall-asm.exe patches/dialog_money_fix.asm --memory-args=\'patch=0x1207\'
Can it be something like --memory-args=name1=0x1207,name2=0x1337?

Other thing - bytes string have no longer guaranteed % 2 == 0 length, which breaks conversion for scripts :(
$ ./sfall-asm.exe patches/dialog_money_fix.asm --memory-args=\'patch=0x480E1F\'

from sfall-asm.

ghost2238 avatar ghost2238 commented on September 25, 2024

Implemented, but with a small adjustment, --memory-args use ' instead of " to avoid escaping.

from sfall-asm.

ghost2238 avatar ghost2238 commented on September 25, 2024

It's not needed unless support for spaces is needed, which isn't needed, at the moment. It was more of a convention thing I guess. I'll remove it.

Thanks for once again catching me doing too little testing and error checking, I'll fix the byte string length by padding with zeroes, should fix the issue :)

from sfall-asm.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.