Giter Club home page Giter Club logo

Comments (3)

ghandic avatar ghandic commented on June 9, 2024

You don't need to specify content encoding, the reason it's failing is it's using pydantic v2, we haven't done any testing on that yet.

from jsf.

mtache avatar mtache commented on June 9, 2024

Hi @ghandic,
Would it be acceptable to update this line: https://github.com/ghandic/jsf/blob/main/jsf/schema_types/string.py#L127 ?
From:

contentEncoding: Optional[content_encoding.ContentEncoding]

To:

contentEncoding: Optional[content_encoding.ContentEncoding] = None

Like the other fields ?
Indeed, how to define a field as optional as changed in pydantic v2 https://docs.pydantic.dev/2.1/migration/#required-optional-and-nullable-fields.

I've tested this and it worked fine.

from jsf.

mtache avatar mtache commented on June 9, 2024

Please ignore my comment, I can see this is already part of #77 😊

from jsf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.