Comments (5)
Not really, but it's also harmless: it doesn't hurt our criteria of a "valid" module, and we can easily generate backend code for this statement, so it feels more future-proof.
from naga.
Agreed, and we are free to modify the IR, as long as we can verify the integrity of both the input and output. This will always be a case by case situation to choose it we would add it to our generic statement or create an explicit statement for it.
from naga.
Pretty sure this is addressed. We call plenty of functions now.
from naga.
I'm thinking if something more generic will be appropriate. Maybe Statement::Expression(expr)
?
from naga.
Sure, but at the moment I cannot think of another use case where we would require this generic statement. Do you maybe know more cases?
from naga.
Related Issues (20)
- Panic: gsamplerCubeArrayShadow isn't supported HOT 3
- [wgsl-in] Comparing scalar with vector type incorrectly passes validation
- Support for the .glsl extension HOT 3
- [wgsl-in] `sign()` incorrectly does not accept i32 arguments
- WGSL backend writes invalid WGSL in some cases HOT 7
- `indexmap` dependency is out of date HOT 1
- [hlsl-out] Miscompilation of array return types HOT 5
- Implement WGSL abstract types HOT 2
- In Firefox, Naga may prefer `std`'s default DOS-resistant hash functions HOT 2
- Missing validation: Adding initializer to workgroup variable declaration in WGSL causes shader compiler error
- Show exact place where shader failed in Firefox Nightly HOT 1
- [wgsl-in] vector constructor and splat constructors require decimal point for float types HOT 2
- Shader translation error, no function with name 'fwidth' HOT 11
- [wgsl-in] Why can't I use mat2x2<f32> as an instance input? HOT 1
- wgpu error: Validation Error HOT 1
- OOM triggered when compiling wgsl shader HOT 1
- Index out of bounds in lower/mod.rs
- Wrong number of arguments error is wrong/misleading HOT 9
- DO NOT FILE ISSUES ON THIS REPOSITORY
- A stack overflow vulnerability was found HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from naga.