Giter Club home page Giter Club logo

Comments (6)

gfranko avatar gfranko commented on August 27, 2024

Interesting, thanks for reporting this! I will make sure that if the esprima comment option is set to true (it is by default), then comments will show up. I'll try to get this done by tomorrow.

from amdclean.

ooxi avatar ooxi commented on August 27, 2024

Aren't sourcemaps made for this? You just have one verison of your file (the minified one) but can see all comments and structure like in the unminified version.

from amdclean.

nstadigs avatar nstadigs commented on August 27, 2024

gfranko: awesome! Thanks.

ooxi: Sourcemaps are great, but I don't want to force the user to host both the source, the sourcemap and the minified file just to be able to read the source. If the user would like to be able to read the source in production, he/she would have to generate a sourcemap from the unminified, amdcleanified source file, since he/she would be doing that for all the other files in his/her project anyway. This is one reason that I need to keep the comments in that version of the file.

from amdclean.

gfranko avatar gfranko commented on August 27, 2024

I just released AMDClean 0.7.0, which will no longer strip comments by default! Check out the release notes for more details.

Thanks again for reporting this!

from amdclean.

gfranko avatar gfranko commented on August 27, 2024

Reopening due to comments still being stripped inside of function blocks. This is still an issue.

from amdclean.

gfranko avatar gfranko commented on August 27, 2024

This has been fixed in the 1.4.0 release.

from amdclean.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.