Comments (6)
Interesting, thanks for reporting this! I will make sure that if the esprima comment
option is set to true (it is by default), then comments will show up. I'll try to get this done by tomorrow.
from amdclean.
Aren't sourcemaps made for this? You just have one verison of your file (the minified one) but can see all comments and structure like in the unminified version.
from amdclean.
gfranko: awesome! Thanks.
ooxi: Sourcemaps are great, but I don't want to force the user to host both the source, the sourcemap and the minified file just to be able to read the source. If the user would like to be able to read the source in production, he/she would have to generate a sourcemap from the unminified, amdcleanified source file, since he/she would be doing that for all the other files in his/her project anyway. This is one reason that I need to keep the comments in that version of the file.
from amdclean.
I just released AMDClean 0.7.0
, which will no longer strip comments by default! Check out the release notes for more details.
Thanks again for reporting this!
from amdclean.
Reopening due to comments still being stripped inside of function blocks. This is still an issue.
from amdclean.
This has been fixed in the 1.4.0
release.
from amdclean.
Related Issues (20)
- Module config HOT 1
- source-map: sourcesContent lost HOT 1
- does amdclean support amd-feature loader plugin
- AMD checks transformations HOT 1
- Problems with "module" special dependency HOT 3
- require with named callback -- the callback is never called HOT 1
- bin/amdclean HOT 1
- AMD destroys multiline return statements HOT 3
- The variable conflict logic in v2.4.0 and onwards HOT 2
- var a = require('a') => var a = a;
- Bad output
- Deal with conditional loader HOT 1
- A comment in return statement leads to incorrect javascript
- function of the calling module goes before the called module: Cannot read property of undefined HOT 1
- Failed to require relative path
- UMD generated by rollup not recognized HOT 1
- define(modulename, dependencies...
- Bug: aggressiveOptimizations may shadow globals
- Comma-separated calls to define don't get translated HOT 1
- npmjs release update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amdclean.