Comments (6)
Same goes for me, @gfranko. I'm working on defining d3.chart with AMD, but its dependency on DataMap (which uses UMD) seems to be causing problems,
Here's the branch I'm working on:
jugglinmike/d3.chart@misoproject:v0.2...v0.2-amd
A manual fix (included in the above branch) is quite simple, but I don't yet understand your project well enough to know exactly what's going wrong. The specific change is at this commit: jugglinmike/d3.chart@d982ee5
amdclean is exactly the tool I've been looking for, and (provided this actually is a bug) I'd be happy to help out if at all possible!
from amdclean.
Hey guys,
I am looking into this and will hopefully have a solution soon.
from amdclean.
I just released v0.5.0, which tries to do a better job of cleaning shimmed libraries. You should now be able to use the onModuleBundleComplete
config property to properly clean your code. You can use it like this:
onModuleBundleComplete: function (data) {
var fs = require('fs'),
amdclean = require('amdclean'),
outputFile = data.path;
fs.writeFileSync(outputFile, amdclean.clean({
'code': fs.readFileSync(outputFile),
'globalObject': true
}));
}
Also, you now have the option to override module return values and set custom return values using the shimOverrides
option.
Important Note: The shimOverrides
option only accepts expressions right now.
In the future, if AMDClean ever has a problem cleaning a shimmed library (e.g. if the Require.js API for shimming libraries changes), then you can use the shimOverrides
option, like this:
onModuleBundleComplete: function (data) {
var fs = require('fs'),
amdclean = require('amdclean'),
outputFile = data.path;
fs.writeFileSync(outputFile, amdclean.clean({
'code': fs.readFileSync(outputFile),
'globalObject': true,
'shimOverrides': {
'backbone': 'window.Backbone'
}
}));
}
from amdclean.
I just released AMDClean v0.6.0
, which now allows you to reliably use AMDClean for your web apps. Check out the release notes and let me know if you have any questions!
from amdclean.
Just wanted to say, great work @gfranko!
from amdclean.
Thanks @ooxi ! I appreciate the kind words.
from amdclean.
Related Issues (20)
- Module config HOT 1
- source-map: sourcesContent lost HOT 1
- does amdclean support amd-feature loader plugin
- AMD checks transformations HOT 1
- Problems with "module" special dependency HOT 3
- require with named callback -- the callback is never called HOT 1
- bin/amdclean HOT 1
- AMD destroys multiline return statements HOT 3
- The variable conflict logic in v2.4.0 and onwards HOT 2
- var a = require('a') => var a = a;
- Bad output
- Deal with conditional loader HOT 1
- A comment in return statement leads to incorrect javascript
- function of the calling module goes before the called module: Cannot read property of undefined HOT 1
- Failed to require relative path
- UMD generated by rollup not recognized HOT 1
- define(modulename, dependencies...
- Bug: aggressiveOptimizations may shadow globals
- Comma-separated calls to define don't get translated HOT 1
- npmjs release update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amdclean.