Third party shimmed libraries. about amdclean HOT 6 CLOSED

Same goes for me, @gfranko. I'm working on defining d3.chart with AMD, but its dependency on DataMap (which uses UMD) seems to be causing problems,

Here's the branch I'm working on:
jugglinmike/d3.chart@misoproject:v0.2...v0.2-amd

A manual fix (included in the above branch) is quite simple, but I don't yet understand your project well enough to know exactly what's going wrong. The specific change is at this commit: jugglinmike/d3.chart@d982ee5

amdclean is exactly the tool I've been looking for, and (provided this actually is a bug) I'd be happy to help out if at all possible!

from amdclean.

Hey guys,

I am looking into this and will hopefully have a solution soon.

from amdclean.

I just released v0.5.0, which tries to do a better job of cleaning shimmed libraries. You should now be able to use the onModuleBundleComplete config property to properly clean your code. You can use it like this:

onModuleBundleComplete: function (data) {
  var fs = require('fs'),
    amdclean = require('amdclean'),
    outputFile = data.path;
  fs.writeFileSync(outputFile, amdclean.clean({
    'code': fs.readFileSync(outputFile),
    'globalObject': true
  }));
}

Also, you now have the option to override module return values and set custom return values using the shimOverrides option.

Important Note: The shimOverrides option only accepts expressions right now.

In the future, if AMDClean ever has a problem cleaning a shimmed library (e.g. if the Require.js API for shimming libraries changes), then you can use the shimOverrides option, like this:

onModuleBundleComplete: function (data) {
  var fs = require('fs'),
    amdclean = require('amdclean'),
    outputFile = data.path;
  fs.writeFileSync(outputFile, amdclean.clean({
    'code': fs.readFileSync(outputFile),
    'globalObject': true,
    'shimOverrides': {
        'backbone': 'window.Backbone'
    }
  }));
}

from amdclean.

I just released AMDClean v0.6.0, which now allows you to reliably use AMDClean for your web apps. Check out the release notes and let me know if you have any questions!

from amdclean.

Just wanted to say, great work @gfranko!

from amdclean.

Thanks @ooxi ! I appreciate the kind words.

from amdclean.