Giter Club home page Giter Club logo

Comments (3)

gfcwfzkm avatar gfcwfzkm commented on July 26, 2024 1

Misclick.

Anyways, I agree there that using different keywords or treating the same keywords between implementations and the documentation is not a good thing there. I'll take a closer look soon into it and change the code implementations accordingly. Thanks!

from pif-image-format.

gfcwfzkm avatar gfcwfzkm commented on July 26, 2024 1

I've finally took a closer look to it and compared all implementations against eachother an the documentation. The correct term, for 'Color Table Size' is the number of bytes that the table holds.
The documentation has been changed to state it better, together with a note to state it more clearly. On top of that, it seemed like the C implementation had a bug, which has been fixed now.

The documentation has been changed to state the following on the first page:

Note: While ColorTableSize states the amount of bytes in the ColorTable, the ImageType states how many bytes make up a color.
On the second page, the details regarding the Color Table Size state now:
Size of the color table in bytes, only used in Indexed mode, otherwise zero.

What do you think, is it more clear now?
Thanks in advance!

from pif-image-format.

generalmimon avatar generalmimon commented on July 26, 2024 1

What do you think, is it more clear now?

Yes, now it looks great. Thank you for addressing this issue.

from pif-image-format.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.