Giter Club home page Giter Club logo

Comments (5)

martinmitrevski avatar martinmitrevski commented on July 30, 2024 1

Hi @masarusanjp,

Thanks for reporting, we will have a look. @laevandus an interesting one for you 🇯🇵

from stream-chat-swiftui.

laevandus avatar laevandus commented on July 30, 2024 1

Hi @masarusanjp, I checked the proposed fix and we'll include it with the next release. Thank you!

from stream-chat-swiftui.

laevandus avatar laevandus commented on July 30, 2024 1

Hi @masarusanjp This issue is fixed in 4.58.0 Thank you for reporting!

from stream-chat-swiftui.

masarusanjp avatar masarusanjp commented on July 30, 2024

When IME candidates are displayed, markedTextRange becomes non-nil, so it seems that assigning an empty string to InputTextView is not being executed.

https://github.com/GetStream/stream-chat-swiftui/blob/main/Sources/StreamChatSwiftUI/ChatChannel/Composer/ComposerTextInputView.swift#L46

This issue was resolved with the following fix, but sorry since I have not yet confirmed whether this fix causes any other issues, so I providing the diff for reference.

- if uiView.markedTextRange == nil {
+ if uiView.markedTextRange == nil || text.isEmpty {

from stream-chat-swiftui.

masarusanjp avatar masarusanjp commented on July 30, 2024

Thank you for the quick response and for including the fix in the next release. I'm looking forward to it!

from stream-chat-swiftui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.