Input is too high when chat is presented in UITabBarController about stream-chat-swift HOT 19 CLOSED

@mpodeszwa ok I’ll think how to fix it

from stream-chat-swift.

Thanks! I'll check.

from stream-chat-swift.

We are also experiencing this as well

from stream-chat-swift.

Hi guys, it should be fixed in the last release.
Let me know if it still there.

from stream-chat-swift.

Hi @buh ,
It's almost fixed :) It works if tab bar is translucent, but if this flag is turned off then problem is still there. I rebased my branch, you can check it out https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset

from stream-chat-swift.

Fixed in the next version 1.4.0.

from stream-chat-swift.

Hi @buh ,
I checked out master and unfortunately I don't think it's completely fixed.
This is how chat looks without the tab bar:

And with the tab bar:

I was testing on iPhone 11 Pro Max. I rebased my branch again https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset 😄

from stream-chat-swift.

Hi @buh
After fixing #36 this bug reappeared 😭 #36 is now fixed :)

from stream-chat-swift.

rebased once more https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset :D

from stream-chat-swift.

That's weird. Thanks! I'll check

from stream-chat-swift.

@mpodeszwa Do you mean #36 was fixed and #28 was not?

from stream-chat-swift.

I thought in 1.5.0 #28 was fine and #36 appeared and now in 1.5.1 it's the opposite. To be honest I'm not 100% sure now if #28 was fixed earlier 🤔

from stream-chat-swift.

It was fixed, I used some hack to save additional offset with tabbar height.
But anyway one of our customer has another bug, that I couldn't reproduce and it was really annoying to fix. So, I decide to rewrite the ComposerView position in a new way. It's much more simple and easy to manage. I'm checking why it doesn't work for you.

from stream-chat-swift.

It's fixed v.1.5.3
Your ChatViewController should be embedded properly. The parent view controller at least should have correct safeAreaInsets.

I recommend you to use UIContainerView to embed it properly. Here is my example that works:

from stream-chat-swift.

Hi @buh
Unfortunately it doesn't work for me. I tried using UIContainerView but it's still the same. Can you check out this branch?
https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset

from stream-chat-swift.

Can't make a commit in your fork.
Please update Main.storyboard with this:
Main.storyboard.zip

from stream-chat-swift.

Thanks for quick response, I downloaded your storyboard and it works, but only with translucent tab bar. If I turn this flag off, the input goes higher :/ I can't really turn on translucent tab bar on my app, because it doesn't go well with our designs :(

I checked on iPhone 8 Plus with iOS 11.4

from stream-chat-swift.

Please check master with the fix.

from stream-chat-swift.

Awesome, works great now :) Thanks 👍

from stream-chat-swift.