Giter Club home page Giter Club logo

Comments (2)

getsantry avatar getsantry commented on August 24, 2024

Routing to @getsentry/product-owners-other for triage ⏲️

from sentry.

keeakita avatar keeakita commented on August 24, 2024

Y'know, I thought I could solve this in some fairly generic way, but this API is really painful. The options:

  • Use mark_safe() in a central location. Doesn't work well because some of these templates have objects in their context that aren't strings.
  • Wrap every email template in {% autoescape off %}, which opens us to regressions in the future if someone misses this
  • Ensure that all templates use the safe filter, which also has the regression issue
  • Define a new backend via TEMPLATES with autoescape=FALSE, then reference it by name. This would be fine except for the fact that default loader.render_to_string, used in multiple parts of the codebase, when not given a value for using=, will iterate through all configured engines. Adding an engine with autoescape turned off could result in unsafe renders app-wide! That's mildly terrifying.
  • Create a whole new engine or backend instance just for rendering the plaintext emails. This could cause divergence in the more subtle parts of the logic between rending HTML and text emails, but might have to be the way to go.

from sentry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.