Comments (2)
Routing to @getsentry/product-owners-other for triage ⏲️
from sentry.
Y'know, I thought I could solve this in some fairly generic way, but this API is really painful. The options:
- Use
mark_safe()
in a central location. Doesn't work well because some of these templates have objects in their context that aren't strings. - Wrap every email template in
{% autoescape off %}
, which opens us to regressions in the future if someone misses this - Ensure that all templates use the
safe
filter, which also has the regression issue - Define a new backend via
TEMPLATES
withautoescape=FALSE
, then reference it by name. This would be fine except for the fact that default loader.render_to_string, used in multiple parts of the codebase, when not given a value forusing=
, will iterate through all configured engines. Adding an engine with autoescape turned off could result in unsafe renders app-wide! That's mildly terrifying. - Create a whole new engine or backend instance just for rendering the plaintext emails. This could cause divergence in the more subtle parts of the logic between rending HTML and text emails, but might have to be the way to go.
from sentry.
Related Issues (20)
- New issue filters results in nothing showing up for users testing Sentry with captureMessage HOT 2
- [Metric Alerts] Warning triggers notificaiton despite no action for Warning status HOT 4
- GET Calls in Transaction details in Trace View should be better formatted HOT 1
- Timestamps on breadcrumbs don't show AM/PM indicator for 12-hour format HOT 1
- Session Replay across multiple iframes simultaneously HOT 2
- No event id or timestamp on the header of a trace
- Notify user when a new identity is linked or removed from their account
- LLM Monitoring not working for Async OpenAI requests HOT 3
- Missing Instrumentation Span design needs to be less pronounced so that users can easily skim over it
- Allow enabling/disabling GitHub integration's PR comment feature per project HOT 2
- Discord integration should accept Channel ID and Channel URL as well when creating an alert HOT 4
- Grouping replays by sessions HOT 3
- Single Developer Slack integration HOT 3
- Promo code is ignored if user signs up using Google HOT 2
- Releases coming from Android are not shown in releases overview even though same package is used HOT 2
- AD Group Members Not Syncing Correctly After SSO Identity Link and Team Slug Change in Sentry HOT 2
- Ability to import / export dashboards as yaml
- Incorrect pip command listed in Performance Start Checklist options HOT 2
- Support sorting trace samples by duration and timestamp
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry.