Logging integration: filter messages about sentry-dotnet HOT 8 CLOSED

You can configure the minimal level which a log entry has to be equal or higher in order to record a breadcrumb:

There's the same for sending event:

Besides that, you can use the MEL filter settings, like in this example:

In this example, I completely disable log messages coming from ExceptionHandlerMiddleware for the SentryLogger. Your other loggers will still get those messages, but they won't reach the SentryLogger.

One other approach is using the Filter property in the SentryLoggingOptions object:

One caveat is that besides the first switches that set different levels for Breadcrumb and Sending event, the others will avoid the log message becoming a either a breadcrumb or an event.

from sentry-dotnet.

To give a better API to add filters, I raised this PR: #90

Having the IReadOnlyList<IFilter> wasn't really the best experience I believe.

from sentry-dotnet.

Great, thanks for all the details

from sentry-dotnet.

Let me know how that works out for you. I'm using the API on a project but haven't had to filter too much stuff yet

from sentry-dotnet.

I'm having trouble getting a Log filter working with an Asp.Net core app running Sentry 1.0, here is my sample code:

.UseSentry(o =>
{
    o.Dsn = Environment.GetEnvironmentVariable("SENTRY_DSN");
     o.MinimumEventLevel = LogLevel.Critical;
     o.MinimumBreadcrumbLevel = LogLevel.Warning;

     o.AddLogEntryFilter((category, level, eventId, exception) => string.Equals(category, "Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager", StringComparison.Ordinal));
}                

I am seeing breadcrumbs with this category.

from sentry-dotnet.

From what I can tell in SentryLogger.cs, even though the extension method says it's for messages & breadcrumbs, the filters are only applied to logged messages. So even if a message is filtered from going to Sentry it's still added to the breadcrumb list.

from sentry-dotnet.

Perhaps it was documented wrong in this case, could you please point me where it mentions filtering breadcrumbs so I can fix it?

There's a BeforeBreadcrumb callback that could be used to filter breadcrumbs. The logger category goes into the breadcrumb category so it's a good way to filter IMHO.

In case you don't want it either as event nor as breadcrumb, perhaps using the framework's filter?

Somethingnlike on appsettings.json:

{
  "Logging": {
    "LogLevel": {
      "Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager": "None"
    }
}

from sentry-dotnet.

Perhaps it was documented wrong in this case, could you please point me where it mentions filtering breadcrumbs so I can fix it?

There's a BeforeBreadcrumb callback that could be used to filter breadcrumbs. The logger category goes into the breadcrumb category so it's a good way to filter IMHO.

In case you don't want it either as event nor as breadcrumb, perhaps using the framework's filter?

Somethingnlike on appsettings.json:

{
  "Logging": {
    "LogLevel": {
      "Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager": "None"
    }
}

In SentryLoggingOptionsExtensions.cs, the extension method comment says:

/// Filters are called before recording a log message as a breadcrumb or sending event.
/// This allows the filter to decide whether the log message should not be recorded at all.

from sentry-dotnet.