Add more built in metrics units about sentry-dotnet HOT 4 CLOSED

https://develop.sentry.dev/delightful-developer-metrics/sending-metrics-sdk/#units-support

for example: 'byte'

I added a custom one and assumed "bytes" and sentry doesn't format that nicely.

I think this is a server side thing. When we transmit the unit to Sentry, the unit is simply transmitted as a string in the statsd protocol:

Since we're leveraging MeasurementUnit under the hood for the .NET SDK metrics implementation, that means it's this:

If we had other enum values, all that would do is give us an indirect way of passing a different string to statsd - but you can do that already with a custom metric.

I suspect in your case it was because you used bytes rather than byte.

from sentry-dotnet.

Might be worth adding those to MeasurementUnit as well though, to avoid typos like this.

from sentry-dotnet.

Unless I've misunderstood, it looks like MeasurementUnit already supports all of these:

• MeasurementUnit.Duration.cs
  
• MeasurementUnit.Fraction.cs
• MeasurementUnit.Information.cs

@bruno-garcia in the code where you were having problems, were you using a custom MeasurementUnit or did you use MeasurementUnit.Information.Byte?

from sentry-dotnet.

Looks like this is covered by MeasureUnit.Information.Byte and Sentry accepts both.

On Sentry:
MeasurementUnit.Custom("bytes")

MeasureUnit.Information.Byte

from sentry-dotnet.