Giter Club home page Giter Club logo

Comments (6)

beonde avatar beonde commented on May 29, 2024 1

@Ninjaman494 Thats a good work around. Thanks for the suggestion! I think I’ll implement that for a fix

from action-release.

beonde avatar beonde commented on May 29, 2024

@Ninjaman494 I would love to see this option too please. We are running 3 distributions and one is built using a Github Action Workflow. Unfortunately that is also the only one for which sourcemaps is not working because we don't have this option.

It is an easy add and the usage could look like:

- name: Create Sentry Release
  uses: getsentry/action-release@v1
  env:
    SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
    SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
    SENTRY_PROJECT: 'my-project-name'
  with:
    environment: 'prod'
    sourcemaps: './sourcemaps'
    version: '[email protected]+a123456'
    dist: 'web'

from action-release.

Ninjaman494 avatar Ninjaman494 commented on May 29, 2024

@beonde I forked this repo and tried adding it, but it was harder than I thought. It's been awhile since I looked at it, but from what I remember I was having trouble actually testing my changes. The action is setup to pull a Docker container that contains a build, so simply forking and pushing up changes wasn't enough. You're welcome to take a look though: https://github.com/Ninjaman494/action-release.

I ended up using the Sentry CLI to upload the sourcemaps in my GHA workflow:

- name: Setup Sentry CLI
  uses: mathieu-bour/[email protected]
  with:
    token: ${{ secrets.SENTRY_AUTH_TOKEN }}
    organization: ${{ secrets.SENTRY_ORG }}
    project: ${{ secrets.SENTRY_PROJECT }}
- name: Create Sentry release
  run: |
    sentry-cli releases \
    files com.example.app@${{ env.VERSION_NAME }}+${{ env.VERSION_CODE }} \
    upload-sourcemaps \
    --dist ${{ env.VERSION_CODE }} \
    android/app/build/generated/assets/react/release/index.android.bundle android/app/build/generated/sourcemaps/react/release/index.android.bundle.map

from action-release.

twogood avatar twogood commented on May 29, 2024

@mgaeta Any chance of getting this fixed soon? Thanks!

from action-release.

anonimitoraf avatar anonimitoraf commented on May 29, 2024

If dist (in events) isn't a must-have, assigning dist = '' in Sentry.init seems strip it (as opposed to dist = undefined or dist = null).

from action-release.

fubhy avatar fubhy commented on May 29, 2024

Same requirement here. We are uploading sourcemaps to different projects within the same version identifier / release from a monorepo.

from action-release.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.