Comments (6)
@Ninjaman494 Thats a good work around. Thanks for the suggestion! I think I’ll implement that for a fix
from action-release.
@Ninjaman494 I would love to see this option too please. We are running 3 distributions and one is built using a Github Action Workflow. Unfortunately that is also the only one for which sourcemaps is not working because we don't have this option.
It is an easy add and the usage could look like:
- name: Create Sentry Release
uses: getsentry/action-release@v1
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
SENTRY_PROJECT: 'my-project-name'
with:
environment: 'prod'
sourcemaps: './sourcemaps'
version: '[email protected]+a123456'
dist: 'web'
from action-release.
@beonde I forked this repo and tried adding it, but it was harder than I thought. It's been awhile since I looked at it, but from what I remember I was having trouble actually testing my changes. The action is setup to pull a Docker container that contains a build, so simply forking and pushing up changes wasn't enough. You're welcome to take a look though: https://github.com/Ninjaman494/action-release.
I ended up using the Sentry CLI to upload the sourcemaps in my GHA workflow:
- name: Setup Sentry CLI
uses: mathieu-bour/[email protected]
with:
token: ${{ secrets.SENTRY_AUTH_TOKEN }}
organization: ${{ secrets.SENTRY_ORG }}
project: ${{ secrets.SENTRY_PROJECT }}
- name: Create Sentry release
run: |
sentry-cli releases \
files com.example.app@${{ env.VERSION_NAME }}+${{ env.VERSION_CODE }} \
upload-sourcemaps \
--dist ${{ env.VERSION_CODE }} \
android/app/build/generated/assets/react/release/index.android.bundle android/app/build/generated/sourcemaps/react/release/index.android.bundle.map
from action-release.
@mgaeta Any chance of getting this fixed soon? Thanks!
from action-release.
If dist
(in events) isn't a must-have, assigning dist = ''
in Sentry.init
seems strip it (as opposed to dist = undefined
or dist = null
).
from action-release.
Same requirement here. We are uploading sourcemaps to different projects within the same version identifier / release from a monorepo.
from action-release.
Related Issues (20)
- checkout action deletes workspace files
- New release checklist for 1.3.0
- Only v1 release to point to latest Docker image HOT 7
- New release checklist for 1.3.1
- Cannot pull docker image in Github Action HOT 5
- Add specific permissions for GITHUB_TOKEN
- Add support for uploading debug symbols
- Cannot pull docker image in Github Action HOT 4
- No commits found. Change commits range, initial depth or use --ignore-empty to allow empty patch sets. HOT 8
- Add `~/` as default `url_prefix`
- Normalize the behaviour with `dist` HOT 2
- Wrong commit selection HOT 2
- GHA actions are uploading source maps with dist="null" (string) HOT 4
- Warning when using "dist" as parameter HOT 3
- New release checklist for 1.4.0 (maintainers only). HOT 1
- Run linting and tests as part of the CI
- New release checklist for 1.4.1
- Prepare knowledge transfer for Sentry Release Github Action HOT 1
- Allow space-separated multiple url_prefix
- Upload artifact bundles instead of release bundles HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-release.