Giter Club home page Giter Club logo

Comments (4)

seadowg avatar seadowg commented on July 20, 2024 1

@alyblenkin Playing around with it, I feel like these are actually our two options:

  1. Don't make the list of layers scrollable
  2. Make the list of layers scrollable, but define a max height

Without a max/min height, the scrollable list will grow as much as it can within another scrollable list. That of course results in not a scrollable list as it has infinite room to grow (it's just more scrollable space). I'm going to go with 2, but set a max height so that we'll only see scroll bars for a lot of items (10+).

from collect.

seadowg avatar seadowg commented on July 20, 2024

@alyblenkin how do you think this screen should behave when the static parts (the header and the select access section) are longer than the screen? We could either have everything be scrollable (so it falls of screen but can be scrolled to) and have the list be scrollable within that, or do we want the whole thing to scroll as one?

from collect.

alyblenkin avatar alyblenkin commented on July 20, 2024

Good catch @WKobus!

@alyblenkin how do you think this screen should behave when the static parts (the header and the select access section) are longer than the screen? We could either have everything be scrollable (so it falls of screen but can be scrolled to) and have the list be scrollable within that, or do we want the whole thing to scroll as one?

I could see it working both ways, but I'm leaning towards having everything scrollable, so if it falls off the screen you can still get to it. It's not ideal to have multiple scrollable sections, but I think that's better than the whole thing scrolling as one.

Side note: I also noticed that the title of the bottom sheet is cut off in landscape view.

from collect.

alyblenkin avatar alyblenkin commented on July 20, 2024

Without a max/min height, the scrollable list will grow as much as it can within another scrollable list. That of course results in not a scrollable list as it has infinite room to grow (it's just more scrollable space). I'm going to go with 2, but set a max height so that we'll only see scroll bars for a lot of items (10+).

I think option 2 sounds like a good option with a max height!

from collect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.