Giter Club home page Giter Club logo

Comments (10)

alyblenkin avatar alyblenkin commented on August 21, 2024 1

@seadowg @lognaturel - It sounds like we are going to do this later, but I wanted to capture the two user flows we spoke about:

User only selected unsupported files (doesn't go through the entire flow)

No. layers can't be added
The files you selected are not MBTiles. You can only add MBtiles files.

User selects supported and unsupported files

No. layers can't be added
Some of the files you selected are not MBTiles. You can only add MBtiles files.

Feel free to edit the copy!

Figma

from collect.

lognaturel avatar lognaturel commented on August 21, 2024 1

Looks good! The file type is "MBtiles" with an s so I updated that.

Maybe "The files you selected are not MBTiles. You can only add MBtiles files."

from collect.

seadowg avatar seadowg commented on August 21, 2024 1

I'm thinking we pull that out as a separate issue and solve it separately. That sound ok @alyblenkin and @lognaturel? I guess the real question is: are we OK to handle that case after release?

from collect.

lognaturel avatar lognaturel commented on August 21, 2024 1

Yes, it feels much less likely!

from collect.

alyblenkin avatar alyblenkin commented on August 21, 2024 1

@seadowg so do we want to still do the two flows above, and spin out another issue for the case you mentioned and come back to it later? I want to make sure I'm not blocking anything here!

from collect.

seadowg avatar seadowg commented on August 21, 2024 1

@seadowg so do we want to still do the two flows above, and spin out another issue for the case you mentioned and come back to it later? I want to make sure I'm not blocking anything here!

Yup! Sorry I hadn't had a chance to split it out yet, but will do that now 👍.

from collect.

seadowg avatar seadowg commented on August 21, 2024 1

I was confused there as well! It should be <number of unsupported layers> layers can't be added, so if two couldn't be imported it would be "2 layers can't be added". I'll update the description.

from collect.

seadowg avatar seadowg commented on August 21, 2024

We also at some point need to address the case where a user picks MBTiles files that aren't support by the current engine. In that flow, they just don't end up showing for selection after import. Personally, that feels more confusing but is hopefully less likely to happen? Should we pull out a separate issue for it?

from collect.

alyblenkin avatar alyblenkin commented on August 21, 2024

Good point. I wonder how we would address that. That might be something we could highlight in the docs? Or potentially in the description of the bottom sheet?

from collect.

grzesiek2010 avatar grzesiek2010 commented on August 21, 2024

There is something wrong with the description or maybe with my understanding.
In the description, I see No. layers can't be added in both cases which indicates that in both cases we should block adding layers (all of them). According to what I see on Figma if it's a mix of supported and unsupported layers a dialog should be displayed (to inform users about what happened) but the supported ones should still be imported. @seadowg which source is the correct one?

from collect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.