Comments (10)
@seadowg @lognaturel - It sounds like we are going to do this later, but I wanted to capture the two user flows we spoke about:
User only selected unsupported files (doesn't go through the entire flow)
No. layers can't be added
The files you selected are not MBTiles. You can only add MBtiles files.
User selects supported and unsupported files
No. layers can't be added
Some of the files you selected are not MBTiles. You can only add MBtiles files.
Feel free to edit the copy!
from collect.
Looks good! The file type is "MBtiles" with an s so I updated that.
Maybe "The files you selected are not MBTiles. You can only add MBtiles files."
from collect.
I'm thinking we pull that out as a separate issue and solve it separately. That sound ok @alyblenkin and @lognaturel? I guess the real question is: are we OK to handle that case after release?
from collect.
Yes, it feels much less likely!
from collect.
@seadowg so do we want to still do the two flows above, and spin out another issue for the case you mentioned and come back to it later? I want to make sure I'm not blocking anything here!
from collect.
@seadowg so do we want to still do the two flows above, and spin out another issue for the case you mentioned and come back to it later? I want to make sure I'm not blocking anything here!
Yup! Sorry I hadn't had a chance to split it out yet, but will do that now 👍.
from collect.
I was confused there as well! It should be <number of unsupported layers> layers can't be added
, so if two couldn't be imported it would be "2 layers can't be added". I'll update the description.
from collect.
We also at some point need to address the case where a user picks MBTiles files that aren't support by the current engine. In that flow, they just don't end up showing for selection after import. Personally, that feels more confusing but is hopefully less likely to happen? Should we pull out a separate issue for it?
from collect.
Good point. I wonder how we would address that. That might be something we could highlight in the docs? Or potentially in the description of the bottom sheet?
from collect.
There is something wrong with the description or maybe with my understanding.
In the description, I see No. layers can't be added
in both cases which indicates that in both cases we should block adding layers (all of them). According to what I see on Figma if it's a mix of supported and unsupported layers a dialog should be displayed (to inform users about what happened) but the supported ones should still be imported. @seadowg which source is the correct one?
from collect.
Related Issues (20)
- Improve select one/multiple question type with column appearances
- Improve select one/multiple question types with no buttons appearance
- The asterisk is not displayed in required questions if the question contains audio
- Improve select one question type with likert appearance
- Improve select one/multiple with audio/video appearance
- The color of the dialog in date widgets
- Savepoint after resetting saved forms in project settings
- Canceling downloading a form with media removes the previously downloaded form HOT 2
- Crash on opening the map (to select an entity) after finalizing a registration form and going to follow-up form
- Support `multiline` appearance
- Not possible to delete drafts and sent instances of form that create or update entity
- Drafts don't appear in "Delete form- saved forms"
- Unable to download a changed file in draft testing
- SQlite syntax error- crash after refreshing list of blank forms containg entity form with property with "."
- Remove grey background on "Ready to send" screen HOT 4
- When moving backwards is disabled and drafts are enabled, resuming at saved question fails on some devices HOT 2
- Reduce memory consumed when parsing Entity List CSV
- Remember last input method selected
- last-saved file can sometimes result in InvalidStructureException
- Create seamless top app bar colour
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collect.