Giter Club home page Giter Club logo

Comments (11)

seadowg avatar seadowg commented on August 21, 2024 1

They do mention that progress indicators can be displayed in a card too, but they no longer have a reference (maybe I'm going mad). Regardless, I don't think it's necessary. The main thing is having a little descriptor so the user knows what's happening.

I think the weird part about the card for me is that we're not then going to show the layers in a card. Maybe we could just show a circular progress indicator in the space where the layers will be?

from collect.

seadowg avatar seadowg commented on August 21, 2024 1

I’ve been wondering why that step takes so long. It’s not doing any copying, it’s just getting the layer names. Shouldn’t that be close to instant?

It is copying it into a cache. Correct me if I'm wrong here @grzesiek2010, but my understanding was that we're doing that so we can inspect the file metadata (to show the tile names). Unless there's another reason, I am now wondering if we could safely do this via the Uri Android gives us (via the Kotlin extension Uri#toFile that I've just spotted) rather than performing the extra copy into our cache.

from collect.

lognaturel avatar lognaturel commented on August 21, 2024 1

I believe there's the same delay twice currently.

from collect.

alyblenkin avatar alyblenkin commented on August 21, 2024

Updated this one @seadowg. Let me know what you think.

from collect.

seadowg avatar seadowg commented on August 21, 2024

In both cases we need to disable all the controls right? I'm worried it might be confusing to have disabled stuff on screen while copying the files.

from collect.

alyblenkin avatar alyblenkin commented on August 21, 2024

In both cases we need to disable all the controls right? I'm worried it might be confusing to have disabled stuff on screen while copying the files.

I think you would only have to disable "Add layers" but they can still cancel or select layer access while it's importing, right? I agree that could be confusing if we had to disable both bottom actions. We can also leave it as is. This was a nice to have.

from collect.

seadowg avatar seadowg commented on August 21, 2024

I think you would only have to disable "Add layers" but they can still cancel or select layer access while it's importing, right?

Yeah, that sounds right! I definitely like the direction of 1 more than 2. I'm not sure about the "card" like background, but it could be that I've just never seen it used like that before.

from collect.

alyblenkin avatar alyblenkin commented on August 21, 2024

I swear they had an image of it in the docs just last week! They do mention that progress indicators can be displayed in a card too, but they no longer have a reference (maybe I'm going mad). Regardless, I don't think it's necessary. The main thing is having a little descriptor so the user knows what's happening.

from collect.

alyblenkin avatar alyblenkin commented on August 21, 2024

Maybe we could just show a circular progress indicator in the space where the layers will be?

That works for me. I think it would still be helpful to have the label "Importing layers" below the progress indicator just in case it takes a while.

from collect.

lognaturel avatar lognaturel commented on August 21, 2024

I’ve been wondering why that step takes so long. It’s not doing any copying, it’s just getting the layer names. Shouldn’t that be close to instant?

from collect.

seadowg avatar seadowg commented on August 21, 2024

@grzesiek2010 I'm thinking we should investigate removing the copy to cache before doing any more design here. It seems like people are seeing a big delay when copying to cache, but then not after "Add layers" for big files (please correct me if I'm wrong anyone). If that's the case, I can imagine that if we do get rid of the copy to cache, we might end up moving that delay to after "Add layers" making optimizing the first progress UI a bit pointless. What do you think?

from collect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.