Giter Club home page Giter Club logo

Comments (6)

lognaturel avatar lognaturel commented on June 12, 2024 2

Oh, but if someone wants to do the same for media (just handling the delete case), I think that would be good as well.

from briefcase.

icemc avatar icemc commented on June 12, 2024 1

@shivam-tripathi regarding this issue i think this solves the problem and i can confirm that the re-downloaded files are exported successfully.
Regarding the file tampering issue that you described above a new issue could be filled so that we could get a detail discussion regarding how to solve that. @yanokwa @rclakmal @lognaturel what do you think?

from briefcase.

icemc avatar icemc commented on June 12, 2024

@yanokwa i would like to work on this

from briefcase.

yanokwa avatar yanokwa commented on June 12, 2024

@icemc Thank you for finding and documenting this bug. Please send in a PR!

from briefcase.

shivam-tripathi avatar shivam-tripathi commented on June 12, 2024

@yanokwa @icemc This is much more complicated. As I mentioned here, if some one deletes/renames the media file, then upon exporting - the file would be skipped, same thing as with submission xml file.
If we are considering tampering - we should in my opinion consider not just submission xml, but also media files. :)
Also, @icemc you are just considering deletion - what if the file has been renamed? Maybe delete such a file. :)
All this is a big hassle. How to ensure data integrity when the entire storage is being compromised? I think this needs some discussion to prevent tampering - and give warning about the risks involved with the tampering if done intentionally. :)

from briefcase.

lognaturel avatar lognaturel commented on June 12, 2024

I think there's only so much we can really do to save users from themselves. Dragging a submission out actually seems like it'd be an easy thing to do accidentally and I do think it makes sense to try to keep the local briefcase consistent on the next pull in case that does happen. Once a user starts renaming files, I kind of feel like they're on their own! But I can be convinced otherwise if someone wants to create an issue and make an argument for doing deeper integrity checks.

from briefcase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.