Don't switch to Push tab when Pull is initiated about briefcase HOT 7 CLOSED

I say go for the refactor! 😊 It seems like a fairly focused change to make that will provide benefits in the future.

Edit: and yes, keeping focus on the last used component sounds right.

from briefcase.

Okay, I´ll work on it sometime this week.

from briefcase.

This behavior also happens after an export.

from briefcase.

This problem seems to be caused by the FocusTraversalPolicy on the MainBriefcaseWindow. In both getComponentBefore and getComponentAfter (line 284 - 357)

tabbedPane.setSelectedIndex(nextPanel);

is called, to switch to the next tab, if no component is found, satisfying the following conditions.

if ( comp == tabbedPane ) {
    return comp;
}

if ( comp.isVisible() && comp.isEnabled() && (!(comp instanceof JTextField) || 
((JTextField) comp).isEditable()) ) {
    return comp;
}

If the cancel button, wich is the component after the pull button is disabled, the conditions will evaluate to false, causing the tab jump.

Instead of jumping to the next tab if no component is found, keeping the focus on the last used component could be a good solution.
In terms of class design, refactoring the tabs to implement their own policies might even be better.
@yanokwa @lognaturel What do you guys think?

from briefcase.

@carstendev I'll leave this issue closed since the surface problem is fixed. We'd love some refactoring if you're still up for it! 😊

from briefcase.

@lognaturel Refactoring is still a good idea, I´ll try to work on it, as soon as I´m not so swamped with work.

from briefcase.

Of course, whenever you have time. Thanks, @carstendev!

from briefcase.