"Revert" and "Save" buttons sometimes still show after clicking "Revert" about kirby HOT 6 OPEN

I don't know if it's related, but I've noticed that ?language=null is appended to the key of each localstorage item (which seems to be used for tracking/persisting change state):

UPDATE: This does not seem related (I've just checked on a v3 site which also has this issue and the language query param is not on the key).

from kirby.

This issue was related to special characters. If you share the content file of the page you have the issue, maybe we can replicate the issue and find a solution.

from kirby.

This issue was related to special characters.

So it's a known issue?

Any further context to point to here (other issues, PRs) (I've looked but haven't been able to find any).

If you share the content file of the page you have the issue, maybe we can replicate the issue and find a solution.

Unfortunately it's within the context of a closed source project.

I'll try to create an isolated test case that reproduces it.

It's worth pointing out the following workaround (that suggests this isn't related to special chars in the content file):

1. On a page with the issue...
2. Reload the page (i.e. click the browser's "refresh" button)
3. Before making any content changes, click the "Revert" button
4. It works (no issue)

However, if you make changes before clicking the "Revert" button it does not work.

from kirby.

Found some context:

• #3798
• #3758
• #3899

from kirby.

Alright, read through some of the past context and found the following:

• I'm only seeing the issue when changes are made inside a text block (i suppose any type of input field that uses prosemirror)
• The issue seems to be from   getting inserted (from pasted content). It's not visible in the editor. I've noticed these characters so far only between sentences when the author used double spaces between them.
• The site I'm seeing this on has lots of migrated content from a legacy WP site. There's lots of poorly formatted HTML that includes   in the plain text source.

from kirby.

Seems the primary PR that previously addressed this (#3758) was mostly around  .

I can reliably reproduce this by pasting HTML that contains   into a writer field instance.

So to reproduce:

1. Open a page with a writer field input
2. Paste html into it that contains   (tried to add this here but it seems GitHub's markdown handling strips it)
3. Save
4. Reload
5. Make a change in the field
6. Click the "Revert" button
7. Notice that the "Change" and "Save" buttons are still there

Question:

Is there any reason to preserve   instances in pasted text? GitHub seems to be stripping it.

Maybe the simplest "fix" is to replace all   instances with actual spaces on paste. To handle existing content in this state the same "replace" approach could be done on save (as a sanitization step).

from kirby.