Giter Club home page Giter Club logo

Comments (2)

danielhenrymantilla avatar danielhenrymantilla commented on July 28, 2024 1

Thanks for reporting this, this is indeed a limitation of safer-ffi's design: we can't really know how to stringify the generic parameters (in the non-opaque case, we get away thanks to the recursive ReprC obligation on the generic parameters, which is the one providing the stringified sub name (the short_name, for those curious about the internals)).

A way to palliate the issue, which I've used in some cases, is to use the undocumented1 rename feature of ReprC::opaque:

#[derive_ReprC]
#[ReprC::opaque(format!(
    "Foo_{}",
    ::std::any::type_name::<T>()
        .splitn(2, "<")
        .next().unwrap()
        .rsplitn(2, ":")
        .next().unwrap()
))]
struct Foo<T> { /* … */ }

it's not pretty, but at the time I did not want to provide this as a default implementation, thence hiding nested collisions.


In the near future

I now think that such implementation, especially if recursing into the generic parameters, is not that bad, and definitely better than just disregarding the type parameters in the name.

Thus, as part of the incoming cleanup and refactoring of safer-ffi, such an implementation will be available by default, thence fixing this very issue 🙂

Footnotes

  1. an oversight, I guess

from safer_ffi.

danielhenrymantilla avatar danielhenrymantilla commented on July 28, 2024

This was fixed as of #97 (to be released to crates.io)

from safer_ffi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.