Giter Club home page Giter Club logo

Comments (2)

danielhenrymantilla avatar danielhenrymantilla commented on July 28, 2024

Thanks for reporting it. The problem lies in:

$(#[$($field_meta)*])*

which is basically the code for the "raw" variant / aspect of the ReprC struct (since ReprC defines a mapping from the higher-level Rust type to a raw #[repr(C)] version of it with no safety invariants attached to it).

  • Screen Shot 2021-02-22 at 18 33 30

And from the code there (modulo macro readability), we can see this raw variant only gets its doc comments forwarded, but not the other ones (because it shouldn't be necessary to have other macros applied to that raw variant, and as we can see here, forwarding macros to things that are not the originally written struct can cause problems).

And the oversight here is that the field attributes are still forwarded!

So not-forwarding the latter ought to fix the issue. I don't have time to make sure this fix won't cause breakage elsewhere (misinteraction between multiple macros is very common and with edge cases everywhere), so I won't merge the PR and make an official release with it yet. But you should be able to use that version using a Cargo [patch]:

[patch.crates-io.safer-ffi]
version = "0.0.5"
git = "https://github.com/getditto/safer_ffi"
branch = "fix/derive_repr_c_and_other_macros"

from safer_ffi.

david-bouyssie avatar david-bouyssie commented on July 28, 2024

Amazing, so fast you are!

Thanks. Will try ASAP.

from safer_ffi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.