add support for username/password authentication? about node-corenlp HOT 5 CLOSED

Hi @roberthaidari, You can fork the repo, push the changes to a branch on your copy and open a PR against this copy. I'd be glad to accept contributions!

from node-corenlp.

Hi @Luke-Tan,

Not possible currently, but I'll take it into account for upcoming updates. If you want to submit a PR, I'd be glad to merge it.

Thanks,

from node-corenlp.

Hi @gerardobort,

Do you have any reccomended ways to add authentication to make calls to the NLP server? Basically I have set up a coreNLP server and my node app queries it with this library. Any idea how I could restrict usage of the server to my app only and not other people who may know the url to my app? I am fairly new to server-side programming and its best practices. Thanks!

from node-corenlp.

Hey @gerardobort I wanted to do a PR to enable this, it's just ~10 additional lines of simple code in connector-server.js

const config = {
  dsn: 'http://localhost:9000',
  auth: {
    user: null,
    pass: null,
  },
};

And an if statement at the bottom. What's the best way to push my branch (I don't have permissions)?

from node-corenlp.

Hi @Luke-Tan, @roberthaidari, the basic auth support it's been added to version 1.4.4. Late but safe!

from node-corenlp.