Giter Club home page Giter Club logo

Comments (7)

benji-glitsos-ga avatar benji-glitsos-ga commented on June 23, 2024 1

Ok I'll close this unless @omad wants to reopen it.

from dea-knowledge-hub.

omad avatar omad commented on June 23, 2024 1

That Contact link in the footer looks good to me Benji!

I'd probably make it not open in a new tab, but happy to close this ticket.

Thanks

from dea-knowledge-hub.

omad avatar omad commented on June 23, 2024 1

I'm generally against forcing things to open in a new tab at all.

But especially in this case, I think we want the DEA sites to feel coherent and that definitely doesn't.

from dea-knowledge-hub.

benji-glitsos-ga avatar benji-glitsos-ga commented on June 23, 2024

In the footer, there is now a Contact us link that goes to that URL that contains the email address.

ksnip_20240207-155041

I can see the email address is featured on a few pages.

Do we need this email address to feature more prominently?

guides/setup/Sandbox/sandbox.rst
154:You can view the current system status `here`_. If you are experiencing an issue with the Sandbox that isn't identified on the status page, please sub [... 1 more match]
195:You can close your account at any time by emailing the DEA team (`[email protected]`_).
201:.. [email protected]: mailto:[email protected]

guides/setup/NCI/account.rst
42:.. _DEA Helpdesk: mailto:[email protected]

data/product/dea-waterbodies-landsat/_faqs.md
148:Contact us at <a href="mailto:[email protected]">[email protected]</a>

data/product/dea-waterbodies-landsat/_access.md
39:If you need more help, contact [email protected]. 

data/product/dea-hotspots/_details.md
20:  * To apply for access, email [email protected]

from dea-knowledge-hub.

robbibt avatar robbibt commented on June 23, 2024

I reckon this is fine for now! I suspect Damien's comment pre-dated Knowledge Hub.

from dea-knowledge-hub.

benji-glitsos-ga avatar benji-glitsos-ga commented on June 23, 2024

Thanks Damien. There is a script on the site that makes all external links (different domain name) open in a new tab. That is causing it. We could consider changing the rule that determines which links open in a new tab? I'll have a think.

from dea-knowledge-hub.

benji-glitsos-ga avatar benji-glitsos-ga commented on June 23, 2024

For consistency with the GA and DEA websites, I'm now making the external links open in the same tab. #102

from dea-knowledge-hub.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.