Giter Club home page Giter Club logo

Comments (5)

yantosca avatar yantosca commented on June 4, 2024 1

I took a quick look at the original repo. Because it's just a few files maybe it could be brought into GCPy directly in a subdirectory.

from gcpy.

yantosca avatar yantosca commented on June 4, 2024

Hi @pennelise and @hannahnesser. I think a vertical regridding capability would be a great addition to GCPy. I think it'd also be nice to have ability to apply the averaging kernels.

I guess we have a couple of options here.

  1. We could open a branch off of dev in geoschem/gcpy and then have you add your changes there, then merge them into the develpment branch.
  2. We could make your existing repository a submodule of GCPy,.. we would make a new folder that links to your repository. (Just like how HEMCO is a submodule of GEOS-Chem).

Either way is good, but I am probably leaning a bit towards the submodule approach...just for the fact that GCST's core competency is not really in averaging kernel manipulation. (Most of GCST's development in GCPy has been benchmarking related.) If people found bugs in your regridding/avg kernel code then it might be more appropriate for them to open an issue on your existing repository rather than on GCPy. I personally have never worked with averaging kernels so if I got an issue I would be at a loss how to fix it.

@msulprizio @lizziel: Thoughts?

from gcpy.

pennelise avatar pennelise commented on June 4, 2024

For 2) we were also concerned about maintenance - Hannah has just graduated and I'm in my 5th year, so I am not sure if we can maintain it (@hannahnesser, any thoughts?).

I think that the satellite operators will have more bugs than the vertical regridding (for example, when the products are updated). And as long as users can regrid, applying the AK is straightforward.

Would it make sense to separate the two functions: a) add the vertical regridding to GCPy and b) keep the satellite operators in a separate repository/submodule?

from gcpy.

github-actions avatar github-actions commented on June 4, 2024

Stale issue message

from gcpy.

github-actions avatar github-actions commented on June 4, 2024

Stale issue message

from gcpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.