Dataset overwriting about geonode-importer HOT 3 CLOSED

So I have been able to update a dataset by changing:

diff --git a/importer/handlers/common/vector.py b/importer/handlers/common/vector.py
index 3a56e16..a26a2b3 100644
--- a/importer/handlers/common/vector.py
+++ b/importer/handlers/common/vector.py
@@ -356,9 +356,7 @@ class BaseVectorFileHandler(BaseHandler):
 
         dataset_exists = dataset_available.exists()
 
-        if dataset_exists and should_be_overwritten:
-            alternate = dataset_available.first().alternate
-        elif not dataset_exists:
+        if not dataset_exists or dataset_exists and should_be_overwritten:
             alternate = layer_name
         else:
             alternate = create_alternate(layer_name, str(_exec_obj.exec_id))

Works for me, but I'm new to GeoNode development, and I'd appreciate to have a comment from someone who knows better.

from geonode-importer.

Hi @sysnux
To overwrite an existing layer is enough to call the upload API by passing the override_existing_layer=True as an additional parameter.
NOTE: be sure that the layer name you are providing matches the alternate that was generated (if is the only dataset available will have the layer_name=alternate), otherwise if you have multiple layers with the same name the system will append a MD5 to make it unique.

For example:

• layer_name = stations
• Does not exist a dataset with the alternate workspace:layer_name -> layer_name / alternate => stations
• Exists a dataset with the alternate workspace:layer_name -> layer_name / alternate => stations / stations_018735210827d5063ed0a1

So you want to overwrite the second layer, the layer name provided must match stations_018735210827d5063ed0a1

With your change, you are risking overwriting an unwanted layer. Two layers can have the same name but have different data in them.

Can you please try to roll back the changes and follow the above point to see if it works?
Thanks

from geonode-importer.

i'll close due the lack of feedback

from geonode-importer.