Comments (11)
geoffder
commented on June 9, 2024
Thanks for the report. It's been a long time so I can't remember, but I think my helper to_file or equivalent used to add the .scad on the end to save the repetition. Guess I droppep it along the way cleaning things up. I'll try to push a fix soon, but in the meantime you can just add the extension to the names in main.ml.
from dometyl-keyboard.
krankydonkey
commented on June 9, 2024
It has been a while hey. I looked at this project a couple of years ago and
really liked it, but couldn't quite get the walls to generate properly.
Getting tired of having all the parts lying around and want to actually
finish it now though 😄
…On Fri, 19 Jan 2024, 12:20 pm Geoff deRosenroll, ***@***.***> wrote:
Thanks for the report. It's been a long time so I can't remember, but I
think my helper to_file or equivalent used to add the .scad on the end to
save the repetition. Guess I droppep it along the way cleaning things up.
I'll try to push a fix soon, but in the meantime you can just add the
extension to the names in main.ml.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKJXKAQJPAARAHZB6S245TYPHJ5HAVCNFSM6AAAAABCBHCKNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGUZTMMRWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from dometyl-keyboard.
geoffder
commented on June 9, 2024
Nice, hope it works out for you this time! I'd like to revisit this and maybe make some improvements while making a new board, but it'll have to wait a bit longer.
from dometyl-keyboard.
krankydonkey
commented on June 9, 2024
Hey while I have you here, is there a way to set the wall generator back to
the old straight segments? I think I prefer that aesthetic to the new
rounded one.
…On Fri, 19 Jan 2024 at 15:39, Geoff deRosenroll ***@***.***> wrote:
Closed #10 <#10> as
completed via #11 <#11>.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKJXKAQFPUO64KQTI4CIHTYPIBIDAVCNFSM6AAAAABCBHCKNOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGUZTGMJUGY4TEMY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from dometyl-keyboard.
geoffder
commented on June 9, 2024
Yeap, roundovers on the keyholes (which get swept into walls) are optional.
dometyl-keyboard/models/examples/splaytyl.ml
Line 104 in 74671ba
The ~corner optional argument is a roundover function. If you remove it, the walls will have sharp corners like they used to. You can also do chamfering, I'd you'd prefer that (see skeletyl example).
from dometyl-keyboard.
krankydonkey
commented on June 9, 2024
I've deleted the ~corner options, and it solves a small section of the
sweep, but I was more talking about the main wall section, which are still
very rounded. I'm trying to get it to look like the ones in the first
picture of the github.
…On Mon, 22 Jan 2024 at 08:56, Geoff deRosenroll ***@***.***> wrote:
Yeap, roundovers on the keyholes (which get swept into walls) are optional.
https://github.com/geoffder/dometyl-keyboard/blob/74671ba6ce1c03f679e8351e3c33ef6008171c63/models/examples/splaytyl.ml#L104
The ~corner optional argument is a roundover function. If you remove it,
the walls will have sharp corners like they used to. You can also do
chamfering, I'd you'd prefer that (see skeletyl example).
https://github.com/geoffder/dometyl-keyboard/blob/74671ba6ce1c03f679e8351e3c33ef6008171c63/models/examples/skeletyl.ml#L85
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKJXKHAOKROKAXL4UCJF5TYPWMITAVCNFSM6AAAAABCBHCKNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSG44TGOJQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from dometyl-keyboard.
geoffder
commented on June 9, 2024
Do you mean the connectors that run along the ground, connecting the walls? There is another ~corner for those here:
Also, you might be wanting to get rid of the fillets, which should be able to be done (sorry don't have time to test) by giving ~fillet_h:(`Abs 0.) in the application of Connect.skeleton.
from dometyl-keyboard.
krankydonkey
commented on June 9, 2024
Sorry, I should have included an image. I mean these curves. You can see
deleting the ~corner options has changed the little segment on the top
right, but the rest of the connector/wall is still swept.
[image: curve.png]
…On Mon, 22 Jan 2024 at 11:40, Geoff deRosenroll ***@***.***> wrote:
Do you mean the connectors that run along the ground, connecting the
walls? There is another ~corner for those here:
https://github.com/geoffder/dometyl-keyboard/blob/74671ba6ce1c03f679e8351e3c33ef6008171c63/models/examples/splaytyl.ml#L82
Also, you might be wanting to get rid of the fillets, which should be able
to be done (sorry don't have time to test) by giving ~fillet_h:(`Abs 0.)
in the application of Connect.skeleton.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKJXKE66GURWEHBKW6L2NDYPW7PTAVCNFSM6AAAAABCBHCKNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSHA3DQMRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from dometyl-keyboard.
geoffder
commented on June 9, 2024
It seems that the image did not make the trip via email.
from dometyl-keyboard.
krankydonkey
commented on June 9, 2024
dang. How about as an attachment
…On Mon, 22 Jan 2024 at 12:13, Geoff deRosenroll ***@***.***> wrote:
It seems that the image did not make the trip via email.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKJXKHSFGVSZQUV56RQ3NDYPXDLFAVCNFSM6AAAAABCBHCKNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSHEYDKNJYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from dometyl-keyboard.
geoffder
commented on June 9, 2024
Afraid not. Taking a guess at what it's about though in the mean time:
For the connectors along the ground, splines are the only option now besides joining the whole height of the wall. Playing with the parameters might get some of the angular look you want back though, like turning ~fn way down (number of points in the spline path). When I was updating I was having trouble coming to a solution for straight connections that I was happy with so I just went with splines (for then, which has lasted until now) since they were less likely to break.
from dometyl-keyboard.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dometyl-keyboard.