package_use always updates conditional USEs about puppet-portage HOT 6 CLOSED

I was able to reproduce this with the following manifest:

package_use { 'app-admin/puppet':
  target => puppet,
  use => ['minimal', ['shadow']],
}

To confirm the intended behavior is if use is given a nested array, it should be flattened?

from puppet-portage.

i would like it to perform (a+b).uniq

from puppet-portage.

I've been thinking about this and I'm not convinced that we should support anything but strings and arrays of strings. With cases like this, it's not clear what the right answer should be and I would rather explicitly fail rather than implicitly try to figure out what was intended. It might make things a bit less flexible but it'll make the module more reliable.

Thoughts?

from puppet-portage.

For what I can tell in most other official modules the arrays of arrays are flattened before processing or output, which is why I used that syntax.

If that's what other modules do, I'd expect the portage module to do the same.

from puppet-portage.

Oh, I didn't realize that. Could you provide an example of that? If that's a common convention used elsewhere I might be able to reuse the code used in other providers.

from puppet-portage.

I looked up some of the modules and all of them do flatten either in the manifest or the template. I will patch accordingly.

from puppet-portage.