Comments (4)
I'll look into it! 👍
from api.
* `affilation` key in `/characters/traveler`(s) has `'Not affilated to any Nation'` string value
Is it better that if the missing key should be nullable instead of undefined or having an empty string?
These API responses are made for clarity, for example "Not affiliated to any Nation" is still information about the character returning a null-able value here could mean that the affiliation is not known or hasn't been added yet or that there is none so the current output provides more clarity.
from api.
* `affilation` key in `/characters/traveler`(s) has `'Not affilated to any Nation'` string value
Is it better that if the missing key should be nullable instead of undefined or having an empty string?
These API responses are made for clarity, for example "Not affiliated to any Nation" is still information about the character returning a null-able value here could mean that the affiliation is not known or hasn't been added yet or that there is none so the current output provides more clarity.
I think it's better to make a new key-value for example affiliated
with a boolean value or something that can be processed and consumed flexibly.
But it will make a breaking changes for the stucture.
from api.
hello, I am debanjan mukherjee ,I would like to change the api and can make it more responsive .I have some projects on that .If you assign me I can do that.
from api.
Related Issues (20)
- constellation-2 image - typo error for Raiden in the website
- Cannot run application with docker-compose HOT 1
- Website out of sync HOT 3
- Add icon-big to thoma HOT 2
- Search via Name HOT 1
- Missing Tighnari Normal Attack
- Add PT language to lang HOT 1
- API DOCS HOT 2
- [Request] homogeneous API response
- [Bug][Refactor] unify keys drops/items HOT 1
- Adding release date attribute to character entity
- Only 57 characters showable HOT 1
- [Invalid] Dendro traveler appears as 4*
- Missing Hunter's Path 5 star weapon
- [Bug] Inconsistent naming for Diluc's burst icon
- Nahida is missing the 'gender' key
- [Bug] Inconsistent Naming with Fontaine Character Icons HOT 3
- Cyno's gender incorrectly marked as female
- Talent Books data uses Incorrect ID for Heizou
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api.