Hello. What do you think about adding a method for performing check that <code class="

Method for checking 7z executable availability about archive7z HOT 5 CLOSED

gemorroj commented on June 18, 2024

Method for checking 7z executable availability

from archive7z.

Comments (5)

Gemorroj commented on June 18, 2024

Can you show similar functionality in other projects or describe why you need this method in real life?

from archive7z.

wapmorgan commented on June 18, 2024

I don't have examples in other projects, but what if for some reason 7z executable disapper from os? Update problems/etc. Just simple isBinaryAvailable() could be called to check it.

from archive7z.

Gemorroj commented on June 18, 2024

You can call null !== $obj7z->getBinary7z().
But in General, there should be no situation when binary path is not available. An exception must be thrown.

Archive7z/src/Archive7z.php

Lines 171 to 186 in 68eddc4

 public function setBinary7z($path) 

 { 

 $binary7z = \realpath($path); 

 if (false === $binary7z) { 

 throw new Exception('Binary of 7-zip is not available'); 

 } 

 if (!\is_executable($binary7z)) { 

 throw new Exception('Binary of 7-zip is not executable'); 

 } 

 $this->binary7z = $binary7z; 

 return $this; 

 }

from archive7z.

wapmorgan commented on June 18, 2024

Ok, but now this method seems to be deleted. Can you provide another static one to avoid object creation?

from archive7z.

Gemorroj commented on June 18, 2024

I would suggest, for example, overriding the makeBinary7z method.

Archive7z/src/Archive7z.php

Lines 72 to 85 in 40e2f86

 public function __construct($filename, $binary7z = null, $timeout = 60) 

 { 

 if (!\is_string($filename)) { 

 throw new Exception('Filename must be string'); 

 } 

 $this->filename = $filename; 

 $this->binary7z = static::makeBinary7z($binary7z); 

 if (!\is_numeric($timeout) && $timeout !== null) { 

 throw new Exception('Timeout must be a numeric or null'); 

 } 

 $this->timeout = $timeout; 

 }

Archive7z/src/Archive7zTrait.php

Lines 56 to 73 in 40e2f86

 protected static function makeBinary7z($binary7z = null) 

 { 

 if (null === $binary7z) { 

 $binary7z = static::getAutoBinary7z(); 

 if (null === $binary7z) { 

 throw new Exception('Can\'t auto detect binary of 7-zip'); 

 } 

 } 

 $binary7z = \realpath($binary7z); 

 if (false === $binary7z) { 

 throw new Exception('Binary of 7-zip is not available'); 

 } 

 if (!\is_executable($binary7z)) { 

 throw new Exception('Binary of 7-zip is not executable'); 

 } 

 return $binary7z; 

 }

The ideology of the library is based on the fact that its base class will be extended.

from archive7z.

Method for checking 7z executable availability about archive7z HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public function setBinary7z($path)
	{
	$binary7z = \realpath($path);

	if (false === $binary7z) {
	throw new Exception('Binary of 7-zip is not available');
	}

	if (!\is_executable($binary7z)) {
	throw new Exception('Binary of 7-zip is not executable');
	}

	$this->binary7z = $binary7z;

	return $this;
	}

	public function __construct($filename, $binary7z = null, $timeout = 60)
	{
	if (!\is_string($filename)) {
	throw new Exception('Filename must be string');
	}
	$this->filename = $filename;

	$this->binary7z = static::makeBinary7z($binary7z);

	if (!\is_numeric($timeout) && $timeout !== null) {
	throw new Exception('Timeout must be a numeric or null');
	}
	$this->timeout = $timeout;
	}

	protected static function makeBinary7z($binary7z = null)
	{
	if (null === $binary7z) {
	$binary7z = static::getAutoBinary7z();
	if (null === $binary7z) {
	throw new Exception('Can\'t auto detect binary of 7-zip');
	}
	}
	$binary7z = \realpath($binary7z);
	if (false === $binary7z) {
	throw new Exception('Binary of 7-zip is not available');
	}
	if (!\is_executable($binary7z)) {
	throw new Exception('Binary of 7-zip is not executable');
	}

	return $binary7z;
	}