Giter Club home page Giter Club logo

Comments (5)

micheles avatar micheles commented on July 29, 2024

LGTM

from oq-hazardlib.

pslh avatar pslh commented on July 29, 2024

I do agree that the hazardlib is stable enough to have a version >= 1.0.

I am not sure the version of the hazardlib should be equal to that of the engine. If we make a change to the engine without changing the hazard lib do we intend to change the version number of the hazardlib without any other changes?

from oq-hazardlib.

daniviga avatar daniviga commented on July 29, 2024

That's a good point @pslh but it never happened in 4 years. We always had versions aligned. We should consider pros and cons of both the options.

We need to take into account that "hazardlib" includes baselib, which is a fundamental part of the engine and changes to the engine often require changes to baselib. Am I wrong @micheles ?

from oq-hazardlib.

pslh avatar pslh commented on July 29, 2024

The dependencies of hazardlib all apply to the engine but not vice-versa. If we add support for different parallel processing frameworks, I could imagine that we might well change the engine without changing the underlying libraries.

If it is really true that a new oq-engine version implies a new hazardlib version and vice-versa, perhaps we should review our decision to have them in separate repositories.

It is possible to use the hazardlib without the engine, so it should be possible to download/install the hazardlib without having to download/install the engine.

We expect code changes in hazardlib not to break the engine, so hazardlib developers already need both repositories.

from oq-hazardlib.

micheles avatar micheles commented on July 29, 2024

it is really true that a new oq-engine version implies a new hazardlib version and vice-versa, perhaps we should review our decision to have them in separate repositories.*

I have been pointing out this for years. I do not remember any major version release having hazardlib changes independent from engine changes.

from oq-hazardlib.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.