python-gcm does not support connection pooling about python-gcm HOT 7 CLOSED

@alexdej Hi! Thanks for raising this issue! Indeed this is a performance problem and we should reuse the underlying TCP connection/socket.

Currently, using json_request you can send push notifications in bulks of 1000, so if you have 1 million tokens you would open 1000 TCP connections to the GCM server.

I've just tested with a few million notifications something along the lines of: https://github.com/mnemonicflow/python-gcm/commit/00a93d69288bc786e30d43df89ef271ac54117ce which should be a good starting point, although this means forcing the clients of the library to use a context manager and existing clients need to update their code.

with GCM(API_KEY) as gcm:
    response = gcm.json_request(registration_ids=registration_ids, data=notification,
                                collapse_key='xyz',
                                priority='high',
                                restricted_package_name="com.mycompany.myawesomeapp,
                                delay_while_idle=True,
                                dry_run=False)

But I think would be better to add another level of indirection and run the cleanup code inside the GCM object by creating a static session object wrapper using the https://docs.python.org/3/library/contextlib.html#contextlib.contextmanager decorator or similar.

Regarding thread safety, I think it should be handled by the client of the library and maybe add an option to the GCM object to specify if you want connection reuse or not.

from python-gcm.

Great! Your suggestion would work fine for our case, though I agree you might want to make the new behavior optional to avoid changing existing clients (and to preserve thread safety of gcm library by default).

from python-gcm.

👍 on reusing connections. @mnemonicflow your suggestion only works if the data is the same for all recipients, right? If the data is unique for everyone you'd have to call gcm.json_request() once per recipient.

from python-gcm.

@tgwizard Yes, the data is the same for all recipients you pass in the registration_ids parameter. If you want to send different data for different recipients you have to group the recipients (preferrably in bulks of 1000) and pass the specific data you want to send to them in a different json_request call.
The underlying TCP connection is still reused due to the session object but as the documentation says http://docs.python-requests.org/en/latest/user/advanced/ the data is NOT.
"Note, however, that method-level parameters will not be persisted across requests, even if using a session."
Method level parameters refers to the parameters of the .post, .get, .put, etc. methods of the requests.Session() object

from python-gcm.

Thanks for the response @mnemonicflow. The session, and TCP connection, reuse will only be enabled when #96 being merged, as now there's a call to requests.post, which creates new sessions for every call. Or am I missing something?

from python-gcm.

@tgwizard Yes! #96 got merged in develop branch https://github.com/geeknam/python-gcm/tree/develop

from python-gcm.

Cool, thank you!

from python-gcm.