Comments (6)
I think you are spot on with a separate button, much cleaner and easier to understand.
from enhanced-toolbar-link-dialog.
Thanks @rasteiner!
@garethworld Yes, it is. Still not sure about if (and how) I'm going to implement this. I'll let you know.
from enhanced-toolbar-link-dialog.
my 2 cents: "oh-hi-mark" was intended only to add to a discussion.
Its a hack that was less hacky than the plugin it was based on: https://github.com/johannschopplich/kirby-writer-marks which at the time required the user to patch the kirby core.
Johann later rewrote his plugin and made it even less hacky than mine, so if you're considering to use one, it should probably be his.
from enhanced-toolbar-link-dialog.
This would be my ideal Kirby link dialog:
The fields would change based on the selected "Link type".
(Mockup based on the link dialog from the Markdown plugin, where it alrady has the radio buttons for "type". I have added the "Page" (plus dropdown) and "File" options).
from enhanced-toolbar-link-dialog.
That is actually a really good idea. I'll have look on that!
Thank your very much for reaching out @garethworld
from enhanced-toolbar-link-dialog.
@garethworld I had some time to let this sink in a bit. While I really like the idea, I'm uncertain that this makes sense from a usability perspective:
- Some of the current interface elements aren't useful for files (e.g. anchor). What should I do? Ignore? Disable?
- I need probably new interface elements so that a user can decide if he want to add a download attribute.
- The download attribute has some restrictins itself. Chrome 65+ and Firefox supporting only same-origin download links.
- How do I distinguish between Pages and Files in the dropdown?
One thing that came into my mind, was to provide a "File" Dialog in the Writer Toolbar:
This aligns not only with the Kirby default textareas, where "Files" is a sperated icon (and Dialog) but provides also a clear responsibility. Furthermore a User doesn't need to learn a new interface. Anyhow, extending the Writer-Toolbar is possible but not in an easy way 🙊
There exists a Plugin called oh-hi-mark by @rasteiner where he solved this issue but to be honest, I really fear the maintence effort if something changes in the core.
I could extend this or create an additional plugin which is part of enhanced-toolbar-link-dialog. I could also provide a new one wich is based on oh-hi-mark. But than you have to download, install and maintain an additional plugin (probably two)...
So it is complicated... But maybe I overthink this a bit. 😂
from enhanced-toolbar-link-dialog.
Related Issues (20)
- Enable link dialog in Kirby Editor HOT 2
- Translation Dutch (NL) HOT 4
- External link link target HOT 1
- Compatibility issue with Kirby 3.6.0 alpha.x HOT 3
- Internal Links should be converted to relative links HOT 5
- Make list size configurable HOT 2
- Optimize user interface HOT 4
- Compatibility with Kirby blocks HOT 19
- Deprecation Warning with php 8.1.3 HOT 7
- Pages don't show up in 3.7 HOT 8
- Cannot delete custom url pages HOT 3
- Invalid model type "Kirby\Cms\Page" expected: "Page" HOT 5
- Improve accessibility of UI HOT 2
- Feature Request: Classes HOT 2
- Feature request: Option to disable the anchor field HOT 6
- Not compatible with latest Kirby release anymore HOT 2
- Impact on kirby modal height HOT 2
- Feature Request: Link to Files
- [K4] 4.0 Compatibility HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enhanced-toolbar-link-dialog.