How to Inject Presenter Dependency to Activity ? about thirtyinch HOT 10 CLOSED

Why aren't you using the Injection as it is right now?

public class BrowseFragment extends Fragment implements BrowseMvpView,
        BrowseAdapter.ClickListener {

    @Inject DataManager mDataManager;

    public BrowseActivity() {
        addPlugin(new TiActivityPlugin<BrowsePresenter, BrowseView>(
                () -> new BrowsePresenter(mDataManager)));
    }

    @Override
    public void onCreate(Bundle savedInstanceState) {
        // call it before super.onCreate because providePresenter will be called there
        ((BaseActivity) getActivity()).activityComponent().inject(this);
        super.onCreate(savedInstanceState);
    }

Alternatively you can inject the dependencies directly into your Presenter. I normally use it like this:

public class BrowsePresenter extends TiPresenter<BrowseView> {

    @Inject DataManager mDataManager;

    public BrowsePresenter() {
        App.component().inject(this).
    }

    // use this for your tests
    @VisibleForTesting
    BrowsePresenter(DataManager dataManager) {
        mDataManager = dataManager;
    }

}

    // use constructor without arguments from the Activity
    public BrowseActivity() {
        addPlugin(new TiActivityPlugin<BrowsePresenter, BrowseView>(
                () -> new BrowsePresenter()));
    }

You have to make sure you can access the component statically somehow

Be careful with Activity scopes. Those scoped don't support orientation changes whereas the Presenter does by default.

from thirtyinch.

Thanks, I have injected the dependencies. But the interface method in the Presenter throws a NPE.
getView().showText("From PRESENTER!!!");

Updated Presenter code

from thirtyinch.

When is your onViewReady inside your acitivy called?
If this method is called before onAttachView Fr the presenter, then it is your view null.

You can by pass it via sendToView or call it after onAttachView

from thirtyinch.

@StefMa onViewReady is called on the BaseActivity's Oncreate
How can i call the getProducts() on the presenter before onAttachView ?

Updated Base Activity

from thirtyinch.

You don't want to call getProducts() from you Activity. Keep you Activity dumb. Instead call getProducts() from Presenter#onAttachView() because that's when the view will become visible to the user.

from thirtyinch.

If i call getProducts() from Presenter#onAttachView() then the mDataManager is null ?

java.lang.NullPointerException: Attempt to invoke virtual method 'rx.Single me.arulnadhan.grocerycorecommon.data.DataManager.getProducts()' on a null object reference

from thirtyinch.

then your injection doesn't work

from thirtyinch.

mDataManager injection is working on the Activity. But it is not working on the Presenter.

Please take a look at the Code

from thirtyinch.

your Activity#onCreate() method is wrong. You're calling inject after super.onCreate(). At that time your presenter is already constructed. Use the code I recommended you above:

    @Override
    public void onCreate(Bundle savedInstanceState) {
        // call it before super.onCreate because providePresenter will be called there
        ((BaseActivity) getActivity()).activityComponent().inject(this);
        super.onCreate(savedInstanceState);
    }

from thirtyinch.

It works. Thanks a lot for the awesome library!

from thirtyinch.