Working with Excessively Long Strings about parser-ts HOT 5 CLOSED

No worries! I'll do some of my own digging and post any updates here.

from parser-ts.

@benrbray - I tracked down the issue. Essentially, the issue stems from the Parser's many combinator, which is used internally by the many combinator in the string module. This combinator has been notorious for causing issues with infinite recursion in the past.

I believe I have figured out a fix to the recursion issue which allows the many combinators to handle infinitely large iterations. Will be pushing a PR soon.

from parser-ts.

Hey @benrbray! Thanks for letting us know!

Unfortunately, I am unable to replicate the recursion issue. For context, here is a CodeSandbox containing the code you posted above. If you check the console, you'll see that all four parsers run as expected.

In addition, we have regression tests in place for the fix for #41 that are currently passing:

Could you perhaps provide more context?

from parser-ts.

Thanks for the quick reply! I think this will be slightly system- and browser-dependent. I tested in a few different environments:

• Ubuntu / Chrome v87 -- stack overflow at string length 1000
• Ubuntu / Firefox v1.0 -- works at length 1000, stack overflow at 2000
• Windows 10 / Chrome v89 -- works at length 1000, stack overflow at 2000
• MacOS / Safari 14 via BrowserStack -- works at length 1000, stack overflow at 2000

Are you able to reproduce the error on strings of say, length 10000?

As for solutions, I haven't dug too much into the parser-ts internals yet, but I wonder if it's possible to write a many sat function specialized to strings that avoids recursion by directly iterating over characters. I'm not sure whether that sort of approach would be compatible with Stream, though.

from parser-ts.

Hey @benrbray - I was in fact able to replicate it when I increased the string length to 10,000. However, I am not really sure where the errors are originating from. I will need to do some further work on this but don't have too much time in the near future so this one might take a bit.

from parser-ts.