Arrow drawing issue in Janggi about chessgroundx HOT 5 CLOSED

The restriction is very practical though. In Chess, and most variants on pychess, all movements are subsets of Q+N, so adding this restriction eliminates all problems caused by any slight mouse slips, especially for long arrows. At least, someone found it useful enough to work on it. Besides, freestyle arrow is still possible with the "moving off the board" gesture, so I don't see a reason to remove the snap completely at all.

The question is: Do we allow Janggi Elephant arrow? On one hand, doing so will worsen the experience of drawing other pieces' (Bishop, Queen, Xiangqi Elephant) length-2 diagonal arrows. On the other hand, it's still an improvement over completely freestyle drawing. I personally don't have any strong views either way.

Maybe we should take this discussion to Discord for more opinions.

from chessgroundx.

@Fulmene you mentioned in pychess lobby chat that you remember what is the root of this issue. I can't :)

from chessgroundx.

Currently, a (2,3) arrow can still be drawn by moving the mouse off the board and back again for a "free style" mode.

This is where the problem is. Now that I checked it, I even commented on this when I first merged the feature :D

Since the function has no way to know what variant is being in effect (by design) though, adding Janggi Elephant here will affect all variants. It's why I'm still unsure about adding the arrow snap.

from chessgroundx.

As I see this restriction (queen+night) has no practical benefit when someone wants to draw an arrow.
It would be much better to enable to draw all the possible pairs of (a,b) to (c,d) instead.
What do you think?

from chessgroundx.

Fixed in ac68943

from chessgroundx.