Consider providing the code check scripts through ign-cmake about gz-cmake HOT 3 CLOSED

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

I think it would be nice to provide a default code_check script, though an individual project may want to add more checks.

@sloretz, do you have any recommendations from your ros2 work about how we could improve our static analysis?

from gz-cmake.

Original comment by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).

I think this issue's scope should be limited to getting what we have (cppcheck) into ign-cmake. It would match the ROS 2 project to put style scripts into a comon spot. ROS2 has ament/ament_lint which are cmake packages that turn style checks into tests.

I can make separate tickets for enhancements if this ticket is going to be implemented.

ROS2 uses cppcheck too, but they also use a tool called uncrustify. It makes fixing errors super easy. The output includes a diff of the change needed to comply.

5: Code style divergence in file 'src/rcl/arguments.c':
5: 
5: --- src/rcl/arguments.c
5: +++ src/rcl/arguments.c.uncrustify
5: @@ -276 +276 @@
5: -  if (args_impl-> num_remap_rules > 0) {
5: +  if (args_impl->num_remap_rules > 0) {
5: 
5: 1 files with code style divergence

Uncrustify doesn't catch everything. There has been some talk about adding support for clang-format.

from gz-cmake.

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

• changed state from "new" to "resolved"

added to ignition-cmake1 in pull request #60

from gz-cmake.