Error when adding U2F key via Firefox about django-u2f HOT 6 CLOSED

Hi Justin,

I'm not sure if this is a bug in django-u2f or in the firefox addon. It's happening because the firefox isn't submitting the version field as part of the registration request. I don't know if compliant implementations of u2f are required to submit the version or not.

from django-u2f.

Thank you for the rapid response, Gavin. I'm not an expert at reading specifications, but my cursory research indicates that version may indeed be a required field: https://fidoalliance.org/specs/fido-u2f-v1.1-id-20160915/fido-u2f-javascript-api-v1.1-id-20160915.html#u2f-operations

I took the liberty of filing an issue in the U2F Firefox add-on repository in hopes of soliciting its author's opinion on the topic: #24

from django-u2f.

As an update to this issue, I just encountered the same error with Firefox Developer Edition 57.0b3, which includes preliminary support for U2F USB keys. I'm not sure what the spec dictates, but the python-u2flib-server library seems to expect and require the protocol version.

@dainnilsson: Given that this appears to be more closely related to u2flib than to django-u2f, do you have any thoughts on this problem?

@jcjones: Many thanks for your hard work on supporting U2F in Firefox. If indeed Firefox is not including the protocol version (U2F_V2) in the request, do you think it should be?

from django-u2f.

@justinmayer Huh! https://www.fidoalliance.org/specs/fido-u2f-v1.1-id-20160915/fido-u2f-javascript-api-v1.1-id-20160915.html#dictionary-u2fregisterrequest-members does show that the RegisterResponse WebIDL should have version. So this is my bug.

dictionary RegisterResponse {
    DOMString version;
    DOMString registrationData;
    DOMString clientData;
};

I've filed bug 1403279 to change this.

from django-u2f.

This bug will be fixed in the next beta of Firefox, 57 beta 5. Thanks for pinging me!

from django-u2f.

This has indeed been fixed in Firefox 57. Thank you, J.C., for all your work on supporting U2F in Firefox! 🎉

from django-u2f.