autoplot.rda argument const is ignored about ggvegan HOT 4 CLOSED

There is also a const argument to autoplot.cca which makes no difference to (scores are identical).

data(dune)
data("dune.env")
CA <- cca(dune)
identical(scores(CA), scores(CA, const = c(2, 1)))

CCA <- cca(dune ~ ., dune.env)
identical(scores(CCA),
          scores(CCA, const = c(2, 1)))

Perhaps the const argument to autoplot.cca can be removed

from ggvegan.

Thanks Richard. I think it is probably best to remove const from the arguments for both autoplot.rda and autoplot.cca. In the former, as you say, it could be passed via ... if needed and in the latter it is ignored (silently - which is bad).

Whether to remove it or not will depend on whether this is too esoteric an argument to devote attention to in ggevegan?

If we keep it, should it be renamed so that the argument is more meaningful?

from ggvegan.

I agree that it is probably best to remove const from both autoplot.rda and autoplot.cca. I have never used this argument before (but there have been a few times when it might have been useful had I found it). If needed, the help for ... could be expanded to give examples of useful arguments in scores.

The argument name is not great, but it is consistent with vegan. Whether it should be renamed there is another question.

from ggvegan.

Thanks @richardjtelford I decided to keep the const argument in autoplot.rda but pass it along now as you suggested.

from ggvegan.