Image Upload option is allowing upload of other mime types about openpicker HOT 3 CLOSED

@gauravtiwari5050 One of the reasons this method was used was because the content-type isn't always correct or present , keeping in mind that the URL given by the user is valid the download was allowed to continue. In a hindsight this looks like a weak fix.

from openpicker.

The new fix tests the content-type against the fileRegex at line 53 in fetch_file.coffee . There is no or condition to avoid any unwanted outcomes.

#Content Type Validation 
if fileRegex.test(content_type)

The fileRegex here is calculated using the if-else condition at lines 30-35 in fetch_file.coffee

#Check user allowed Mime Types
if req.body.allowedMimeTypes == "image/*"
	fileRegex = imageRegex
else if req.body.allowedMimeTypes == "*/*" 
	fileRegex = mimeRegex
else
	fileRegex = new RegExp(req.body.allowedMimeTypes)

Here three cases are happening :

1. If mime type is of form image/* , imageRegex is chosen
2. for mime type of form */*, mimeRegex is chosen
3. else a new regex is formed from the user's given mime type

from openpicker.

@gauravtiwari5050 The new pull request #8 contains a fix for this.

from openpicker.