Giter Club home page Giter Club logo

Comments (7)

lukasgr90 avatar lukasgr90 commented on July 1, 2024 3

My PR allows me to create Flatcar 3139.2.0 based shoots, which become ready.

@vpnachev It would be great, if you could have a quick look (if the general approach is feasible). Anyway I will now work on extending the tests.

from gardener-extension-os-coreos.

christianhuening avatar christianhuening commented on July 1, 2024

This essentially means flatcar 2905.2.6 is the last supported flatcar version until this is implemented/fixed, correct?

from gardener-extension-os-coreos.

vpnachev avatar vpnachev commented on July 1, 2024

Most likely yes, I haven't tried to create a node with Flatcar > 2905.2.6, but guess it will not be a successful operation.

from gardener-extension-os-coreos.

dergeberl avatar dergeberl commented on July 1, 2024

@vpnachev I am not 100% sure but a change of the default cgroup driver on the linked place can have a bigger impact, because it affect all different operating systems. Maybe it is better to add the possibility to configure it in the cloud profile. So the default can be overwritten if needed for an specific os and os version. For example a cgroupDriver field in cloudprofile.spec.machineImages. What do you think?

from gardener-extension-os-coreos.

christianhuening avatar christianhuening commented on July 1, 2024

do i get it right, that this issue is pretty much depending/waiting on gardener/gardener#5325?

from gardener-extension-os-coreos.

vpnachev avatar vpnachev commented on July 1, 2024

Not necessary, this extension is able to amend the kubelet config and make the necessary configuration changes based on the flatcar version in /etc/os-release file. Alternatively, it can check if cgroup v2 is enabled via the presence of the file /sys/fs/cgroup/cgroup.controllers (ref: https://rootlesscontaine.rs/getting-started/common/cgroup2/#checking-whether-cgroup-v2-is-already-enabled).

If you have the capacity, I would be glad to review PRs on this topic.

from gardener-extension-os-coreos.

lukasgr90 avatar lukasgr90 commented on July 1, 2024

I have extended the tests to cover my additions to the cloud config and thus I am now waiting on feedback.

from gardener-extension-os-coreos.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.