Giter Club home page Giter Club logo

Comments (10)

amolenaar avatar amolenaar commented on June 21, 2024 1

This is better, then:

image

from gaphor.

amolenaar avatar amolenaar commented on June 21, 2024

The rows in the greeter are Adw.ActionRows. Hence they have a bold title and smaller (greyish) subtitle.

action row

Do you think it looks out of place?

from gaphor.

bragefuglseth avatar bragefuglseth commented on June 21, 2024

The rows in the app look different from the row in your screenshot (which has a regular title instead of a bold one) 🙂

from gaphor.

danyeaw avatar danyeaw commented on June 21, 2024

Hi @bragefuglseth, I do agree that they look different. However, I'm not sure why. It looks like we are just setting the title and sub title.

from gaphor.

bragefuglseth avatar bragefuglseth commented on June 21, 2024

Could it be because of custom CSS somewhere?

from gaphor.

bragefuglseth avatar bragefuglseth commented on June 21, 2024

Indeed, there's a class in Gaphor's custom stylesheet named .title that has bold styling. Libadwaita uses this internally for its row titles as well, so Gaphor needs to use a different name for it 🙂

from gaphor.

bragefuglseth avatar bragefuglseth commented on June 21, 2024

LGTM! Check if the about window also has changed.

from gaphor.

danyeaw avatar danyeaw commented on June 21, 2024

Reopening until we check the about dialog as well.

from gaphor.

danyeaw avatar danyeaw commented on June 21, 2024

It looks like the About Window is using a normal font for me, are you seeing something different?

image

from gaphor.

amolenaar avatar amolenaar commented on June 21, 2024

Looks good.

from gaphor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.