Giter Club home page Giter Club logo

Comments (4)

olexandr-konovalov avatar olexandr-konovalov commented on August 26, 2024

Indeed, the screen width in HPC-GAP slightly differs - @rbehrends might be able to tell more about the plans to fix this. For now, testinstall.g and other tests just use compareFunction:="uptowhitespace" to ignore this, but if one uses Test directly, unfortunately one have to remember to call it as

Test("tst/grpperm.tst",rec(compareFunction:="uptowhitespace")); 

to compare the result only up to whitespaces.

@ChrisJefferson suggests to make uptowhitespace the default behaviour, at lease for now in HPC-GAP, and use exact comparison only when we want to enforce it. That may be a good thing to do.

from gap.

stevelinton avatar stevelinton commented on August 26, 2024

I agree with Chris, but we should also look at the way SizeScreen works in the HPCGAP UI. Should it set the actual size of the screen window, or the line length available for output from a working thread?

from gap.

rbehrends avatar rbehrends commented on August 26, 2024

The issue is the following code in src/scanner.c:

  /* TODO: This should be -2 instead of -8 and room for the prefix
   * accounted for elswhere. */
  else if ( stream->pos < SyNrCols-8-TLS->noSplitLine ) {

In order to make room for the [n] prefix that threads other than the main one use for their output, I turned the -2 into a -8. Ideally, this should be -2-strlen(prefix), but that can be a bit laborious. A quick fix would use something like -2-6*(TLS->threadID != 0) instead of -8 in the above check, restoring the original width for the main thread and making the test work.

from gap.

fingolfin avatar fingolfin commented on August 26, 2024

The workaround suggested by @rbehrends was added in a year ago or so. Of course it's just a hack, but we'll just deal with it with a new issue should it resurface eventually.

from gap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.