Comments (3)
Spent some time on this. viztracer did trigger this behavior, but it's not 100% viztracer's fault. tornado is using some hacky stuff here. The issue is tornado has a local memoryview
to the bytearray
, which would be fine on its own. However, if there's another reference to the local variable, then the bytearray
(in this case, self._read_buffer_pos) will not be re-sizeable. Personally I don't think this is a safe assumption to make on tornado's side, but I won't bore you with the details if you are not interested.
The reason viztracer triggered it is because viztracer kept an unnecessary reference to the whole code
object, where it has reference to the local variables, for every function, for performance concern.
However, I think it might be reasonable to reconsider the issue now that it breaks stuff. I would probably change viztracer so it will work with tornado. If so, you should be expecting the change soon :)
from viztracer.
@maartenbreddels I fixed the issue and tested it locally. It's released as 0.10.2. You can just pip install viztracer --upgrade
.
If you still have issues with viztracer, please let me know :)
from viztracer.
Yeah, works great! Thanks, and already helpful jupyter/jupyter_client#590
from viztracer.
Related Issues (20)
- ⭐️support pathos.multiprocessing HOT 1
- `log_sparce` works the other way around
- `log_sparse=True` doesn't work with context manager HOT 10
- Time.monotonic makes it impossible to line up distributed traces HOT 1
- NameError HOT 1
- `SNAPTRACE_TRACE_SELF` typo at `snaptrace.c` HOT 2
- JSONDecodeError in report_builder.py HOT 20
- vizviewer fails HOT 2
- command not found: vizviewer HOT 5
- vizobject/vizcounter not working for Inheritance HOT 3
- Bug: args that overlap with viztracer is lost in subprocess.Popen HOT 1
- Unable to use @trace_and_save with multiprocessing HOT 1
- VSCode extension shows blank screen on vscode remote HOT 9
- VsCode里右键选择Trace with Viztracer后报错 HOT 2
- Linux 上 VSCode extension 打开 viztracer 的结果文件出现问题 HOT 4
- No reminder of port conflict when using the parameter "--use_external_processor" HOT 1
- Clear `viztmp` file even if there's something wrong with trace report saving HOT 1
- Please provide Wheels for Apple Silicon HOT 5
- please provide conda package for the latest version of viztracer HOT 2
- Jupyter Support: Why not have a cell magic too HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from viztracer.