Giter Club home page Giter Club logo

Comments (3)

gaogaotiantian avatar gaogaotiantian commented on July 28, 2024

Spent some time on this. viztracer did trigger this behavior, but it's not 100% viztracer's fault. tornado is using some hacky stuff here. The issue is tornado has a local memoryview to the bytearray, which would be fine on its own. However, if there's another reference to the local variable, then the bytearray (in this case, self._read_buffer_pos) will not be re-sizeable. Personally I don't think this is a safe assumption to make on tornado's side, but I won't bore you with the details if you are not interested.

The reason viztracer triggered it is because viztracer kept an unnecessary reference to the whole code object, where it has reference to the local variables, for every function, for performance concern.

However, I think it might be reasonable to reconsider the issue now that it breaks stuff. I would probably change viztracer so it will work with tornado. If so, you should be expecting the change soon :)

from viztracer.

gaogaotiantian avatar gaogaotiantian commented on July 28, 2024

@maartenbreddels I fixed the issue and tested it locally. It's released as 0.10.2. You can just pip install viztracer --upgrade.

If you still have issues with viztracer, please let me know :)

from viztracer.

maartenbreddels avatar maartenbreddels commented on July 28, 2024

Yeah, works great! Thanks, and already helpful jupyter/jupyter_client#590

from viztracer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.