Giter Club home page Giter Club logo

Comments (2)

mahagr avatar mahagr commented on July 29, 2024

@RyanMPierson We may want to tweak the documentation a bit to say that the available variables are fully defined by the theme and if you define a new variable, you need to use it in your own SCSS files in order to them to have any effect.

from docs.

thexmanxyz avatar thexmanxyz commented on July 29, 2024

@mahagr @RyanMPierson First of all thanks for integrating the documentation change. The newly added information is just fine and should also help people in the long run:

The variables listed in the layout presets are defined entirely by the theme, and are not core to Gantry. If you wish to define a new variable, you need to use it in your own SCSS files in order to them to have any effect.

But that still doesn't cover the actual issue I stated. In both of the default and free available themes (Helium / Hydrogen), which are part of Gantry on Github, there is no menustyle variable available but it is still listed in the docs.

It might be used in the paid themes of RocketTheme. TBH IDK what exact attributes listed under Anatomy of the YAML file are really part of the free themes. You know better which of the variables listed under:

Here is a quick breakdown of the main settings and what they do:

are actually part of the open source themes and which are not. I would either state in that table which ones are really available within Hydrogen / Helium or otherwise remove them completely from this documentation page (e.g. in case of the menustyle). Hope this post clear up the actual issue I have with the variables listed on the bottom of the docs page and within the YAML snippet.

It's somewhat inconsistent and confusing because the rest of the docs is also focused on the open source themes and don't touches things that aren't available. How you actually communicate that is up to you but I just can say it confuses people as it currently is and still needs some rework or more information.

/please reopen

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.