Giter Club home page Giter Club logo

Comments (6)

AllanWang avatar AllanWang commented on May 28, 2024 1

If you are interested you can still have a bigger bound for the primary action, and have a bar below it for supplemental actions. The cardview would encompass both.

Example

from gamedevmcgill.ca.

erickzhao avatar erickzhao commented on May 28, 2024

Hey @AllanWang, thanks for submitting an issue! 👋

We had that in a previous build of the website (see fde79a3), but it was ultimately nixed because we also had anchor tags in the card itself linking to each of the tag pages, and nesting anchor tags is semantically invalid according to the W3C spec (although supported in all major browsers).

See: https://www.w3.org/TR/html4/struct/links.html#h-12.2.2

Regardless, the UX does appear to be slightly confusing in its current state, since the hover animation doesn't accurately reflect the click area.

Let me know if you have any other suggestions or problems!

from gamedevmcgill.ca.

erickzhao avatar erickzhao commented on May 28, 2024

I was going to submit a PR but gatsby develop wasn't working in the master branch.

This is also a weird issue. Does the global gatsby-cli module work in general for you? We were able to get it working on a few machines (and the build server) on our end.

from gamedevmcgill.ca.

AllanWang avatar AllanWang commented on May 28, 2024

The build error was related to graphql's allItchioGame. I'm not really a web dev but the query is also not defined anywhere in the repo, so maybe you've gitignored something

from gamedevmcgill.ca.

erickzhao avatar erickzhao commented on May 28, 2024
  • Regarding the clicking: Right, that'd be a workaround for it. I think it'd definitely be something to consider for later, but there are probably higher priority issues for the time being (like adding more club content). Would require some overhead in restyling everything.

  • Regarding your error: Oh I know what that is. We query the itch.io server-side API to get our list of games, but you need a .env with the API key defined. The thing is the plugin I wrote doesn't have a good error message to let the end user know that their API key is missing in the config. 😬

from gamedevmcgill.ca.

erickzhao avatar erickzhao commented on May 28, 2024

See erickzhao/gatsby-source-itchio#1

from gamedevmcgill.ca.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.