Comments (7)
about slash /
issue was also reported here #245
from gon-evidence.
about slash
/
issue was also reported here #245
True! This is more about a possible attack vector related to the fact that timeouts cannot be resolved.
from gon-evidence.
After having looked more at the code and the spec itself, I am holding back on creating a PR. I have some solutions locally that could allow for / characters, but I am not sure it is wise. So, I wonder if this is actually a bug that should be solved slightly differently:
The ICS721 spec itself declares that: If {classId} contains /, then it must also be in the ICS-721 form which indicates that the tokens have a multi-hop record. Note that this requires that the / (slash character) is prohibited in non-IBC token classIds.
From what I can tell, this means that the NFT module should probably not allow the slash character. But the nft-transfer module should also prohibit transfers of native nft classes that has slash character in the name.
from gon-evidence.
@gjermundgaraba were you able to verify that this causes the relayer to be unable to complete the IBC Txs?
is related to the problem between Juno <> Stargaze?
from gon-evidence.
@gjermundgaraba were you able to verify that this causes the relayer to be unable to complete the IBC Txs? is related to the problem between Juno <> Stargaze?
No it is hard to tell right now because there is spam on that channel as well. But I am convinced this would cause the problem to get much worse if these transactions were in there as well because each relayer bundles up a bunch of these transactions and if some of them start to fail...
from gon-evidence.
fwiw, it is possible to correctly process NFT denoms with slashes AFIK, just need to parse from the beginning of the string only: https://github.com/public-awesome/ics721/blob/3af19e421a95aec5291a0cabbe796c58698ac97f/contracts/cw-ics721-bridge/src/ibc_helpers.rs#L11-L28
from gon-evidence.
The problem is in nft-transfer module, it can't transfer the token (denom with slashes) in events such as IBC Rcv, IBC Timeout, IBC Ack with error.
from gon-evidence.
Related Issues (20)
- AWARD: Disperze Claim 3
- AWARD: Disperze Claim 5
- CLOSED
- AWARD: keyllli223 Claim 2
- AWARD: DAICers Claim 6
- AWARD: Xavier Team Claim 4 HOT 1
- AWARD: Ankaria Claim "6 - Best NFT Memes"
- AWARD: silent Claim 6
- AWARD: Stakeflow Claim 2 HOT 2
- AWARD: NSeven Projects Claim 4
- AWARD: LIVE.Node Claim 5
- AWARD: LIVE.Node Claim 6
- closed
- AWARD: Power//Team Claim 6 - MEME
- AWARD:xbdyhh Claim 6 - MEME
- AWARD:DreamGallery Claim 6 - MEME
- AWARD: Ping.pub Claim "2 - Public Good Awards"
- AWARD: NSeven Projects Claim 6
- AWARD: Disperze Claim 5
- AWARD: Disperze Claim 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gon-evidence.