improprer "using namespace std" in header files about pdf-writer HOT 5 CLOSED

Cheers. So i gather that you would like me to edit the h files? I figure only some of them have that trait. Guess i could do tha. Good idea. Got some stuff im working on now, though, so it might take me a while (i say two weeks). Think you can havr a go?

-------- הודעה מקורית --------
מאת: mgubi [email protected]
תאריך:
אל: galkahana/PDF-Writer [email protected]
נושא: [PDF-Writer] improprer "using namespace std" in header files (#3)

I'm trying to evaluate using PDF-Writer as backend to the TeXmacs (www.texmacs.org) scientific editor, however the fact that the PDF-Writer header fields contains "using namespace std" prevents me to include them into the TeXmacs sources since they do not rely on the C++ standard library and we have a different definition for the string class.

In general is a good idea to avoid using that declaration in header files:

http://www.cplusplus.com/forum/beginner/25538/

Btw, nice library! I look forward to be able to use it to write PDFs inside TeXmacs, we really need a good PDF writing library like that.

—
Reply to this email directly or view it on GitHub.

from pdf-writer.

I'm doing just that for my personal use. Do you agree in using explicitly "std::" everywhere? or you would prefer that source files retain the "using namespace std" statement? I would go for the first and more uniform alternative, even if the second can be easier to do.

from pdf-writer.

First is great. Thats what i want to do. Good luck :). I'll keep in touch in case ill get to this early.

-------- הודעה מקורית --------
מאת: mgubi [email protected]
תאריך:
אל: galkahana/PDF-Writer [email protected]
עותק: gal kahana [email protected]
נושא: Re: [PDF-Writer] improprer "using namespace std" in header files (#3)

I'm doing just that for my personal use. Do you agree in using explicitly "std::" everywhere? or you would prefer that source files retain the "using namespace std" statement? I would go for the first and more uniform alternative, even if the second can be easier to do.

—
Reply to this email directly or view it on GitHub.

from pdf-writer.

Ok,
here the patch removing "using namespace std" everywhere. It works for me.

Best
Massimiliano.

On Jan 12, 2013, at 6:44 PM, gal kahana [email protected] wrote:

First is great. Thats what i want to do. Good luck :). I'll keep in touch in case ill get to this early.

-------- הודעה מקורית --------
מאת: mgubi [email protected]
תאריך:
אל: galkahana/PDF-Writer [email protected]
עותק: gal kahana [email protected]
נושא: Re: [PDF-Writer] improprer "using namespace std" in header files (#3)

I'm doing just that for my personal use. Do you agree in using explicitly "std::" everywhere? or you would prefer that source files retain the "using namespace std" statement? I would go for the first and more uniform alternative, even if the second can be easier to do.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

from pdf-writer.

thanks man. merged with the master branch. great :)

from pdf-writer.