Refactor ethers-contract about ethers-rs HOT 4 CLOSED

@gakonst sorry, got busy over the weekend. Have started working on it. Will make some commits in a day or two :)

from ethers-rs.

Hi @gakonst, I'd like to take this up to familiarise myself with the codebase a bit :)

So from what I understand, the task is mainly to split the existing Contract struct to

pub struct BaseContract {
    abi: Abi,
    methods: HashMap<Selector, (String, usize)>,
}

pub struct Contract<M> {
    base_contract: BaseContract,
    client: Arc<M>,
    address: Address,
}

impl BaseContract {
    ....
    
    /// Should be upgradeable to a "full" `Contract` struct.
    pub fn into_full_contract<M>(self, address: Address, client: impl Into<Arc<M>>) -> Contract<M> {
        Contract {
            base_contract: self,
            address,
            client: client.into(),
        }
    }
}

Is this roughly what you have in mind?

It'd also be nice if we supported human readable ABIs.

could you expand on "human readable" a bit?

from ethers-rs.

Hey! Yes, exactly what I had in mind. Human readable ABIs, are the ones from Ethers-js https://blog.ricmoo.com/human-readable-contract-abis-in-ethers-js-141902f4d917

from ethers-rs.

hey @pawanjay176! were you able to take a stab at the issue? If there was anything confusing, could I help you in some way?

from ethers-rs.