cURL Timeout Not Working Properly about php-grab-favicon HOT 7 OPEN

It's being used by the fallback (non curl) as well, but I'm restructuring it a bit. The above is just a quick fix.

from php-grab-favicon.

I'll see if I can do a special branch for this hotfix. My main branch is in the middle of some major rework (including supporting a config file).

from php-grab-favicon.

Nevermind, it looks like you got it, that should be enough for now! :)

from php-grab-favicon.

If you use it like this:

function load($url, $DEBUG, $consoleMode = false, $timeOut = 60) {
  if (function_exists('curl_version')) {
    $timeOut = getGlobal('curl_timeout');
    if (!isset($timeOut )) { $timeOut = 60; }

$timeOut = getGlobal('curl_timeout'); is already set before the function call, so I would implement it like this:

function load($url, $DEBUG, $consoleMode = false, $timeOut = 60) {
  if (function_exists('curl_version')) {
    if (!isset($timeOut )) { $timeOut = 60; }

from php-grab-favicon.

I will be happy with every update-request and promise to merge it ASAP ;-)

from php-grab-favicon.

No Stress, we can do it all in one Step if you like

from php-grab-favicon.

I'm using #9 for my working on list.

from php-grab-favicon.