Support dynamic createClass calls if possible about react-hot-loader HOT 6 CLOSED

This would be awesome.

from react-hot-loader.

👍

Any way we could do your monkeypatching scheme now? I'd like to help on this if possible.

Edit: I am just directly passing displayName, like so:

function(stuff) { return React.createClass(displayName: stuff.name, ...) }

from react-hot-loader.

We'll have to change a lot anyway because 0.13 is coming, and React.createClass will no longer be The Way to create components, slowly being phased out in favor of ES6 classes. We will need to reimplement hot loader considering this (#39), and intuitively I feel that this time createElement will be involved. While we're overhauling the loader for ES6 class support, we might want to also look into supporting dynamic createClass calls and see if any approach solves both problems. I could use any help with brainstorming these approaches in #39, feel free to suggest your ideas!

from react-hot-loader.

This. Is. Coming.

from react-hot-loader.

This should actually Just Work now with 1.0.0-alpha if you opt in explicitly:

function createRedirectHandler(to) {
  var cls = React.createClass({
    displayName: 'redirect-' + to,

    statics: {
      willTransitionTo: function (transition, params, query) {
        transition.redirect(to, params, query);
      }
    },

    render: function () {
      return null;
    }
  });

  // this is new API suitable for the dynamically generated classes:
  if (module.makeHot) {
    // second parameter is some string that uniquely identifies class inside current module
    // (even if it is generated)
    cls = module.makeHot(cls, to);
  }

  return cls;
}

Please give it a spin and report any issues.

from react-hot-loader.

Closing, as this will be in 1.0.

from react-hot-loader.