Supporting ES module imports about babel-plugin-react-transform HOT 12 CLOSED

@guybedford Thanks for your time on this stuff, as always. :)

Might the best solution actually be to revisit babel/babel#2148? Or I'm I wrong in thinking that the algorithm you described there would solve this issue and all others like it? Regardless, it seems to me like there must be some way to determine whether a module was originally ES6, and if so and if it's imported into a CJS module (or another transpiled ES6 module with default specified of course), then use the default rather than the entire ES6 module object.

from babel-plugin-react-transform.

@timbur sure no problem, it's a good use case to cover.

I think the issue here is actually just that the file.addImport API call to Babel needs to access the default export to be like import x from 'x' instead of import * as x from 'x' for correct interop, which should then handle the use case completely fine. This may or may not be a Babel issue underneath, I'm not completely sure yet.

from babel-plugin-react-transform.

When you come to a conclusion let me know and I'll happily add a workaround you think is right.

from babel-plugin-react-transform.

I think the issue here is actually just that the file.addImport API call to Babel needs to access the default export to be like import x from 'x' instead of import * as x from 'x' for correct interop

Ohh I see. That makes the most sense and could be exactly the problem.

from babel-plugin-react-transform.

Sure thanks, I've posted babel/babel#2496.

from babel-plugin-react-transform.

Just to update here - apparently addImport isn't a public API. The issue here is definitely with that function not handling the interop scenarios.

from babel-plugin-react-transform.

I think that actually if I use file.addImport directly (effectively reverting d4c90c7) it will work as you described. Can you confirm this is the change you need?

from babel-plugin-react-transform.

@gaearon No, it still imports the entire module object rather than the default.

Actually, hold on...

from babel-plugin-react-transform.

I thought maybe I could use a JSPM override to make it work but no, d4c90c7 definitely breaks it by importing the entire module object rather than the module's default export.

from babel-plugin-react-transform.

So will reverting it help? I can do that.

from babel-plugin-react-transform.

Yeah reverting it to match my PR fixed the problem for me.

from babel-plugin-react-transform.

I think this is probably fixed because we no longer use absolute in the source.
Please reopen if still an issue.

from babel-plugin-react-transform.